Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adrian Paez specs #25

Closed
wants to merge 16 commits into from
Closed

Adrian Paez specs #25

wants to merge 16 commits into from

Conversation

adriantpaez
Copy link

@adriantpaez adriantpaez commented Feb 25, 2019 •
edited
Loading

Fixes #
#6 Create wallet API endpoint
#10 Delete observation API endpoint
#11 Create balance observation API endpoint
#12 [api] Get history to address

Changes:

  • Add specifications for these API endpoints

@adriantpaez adriantpaez reopened this Feb 26, 2019
@stdevMac
Copy link
Member

skyxcommons/AdrianPaez_spec.yml

Line 154 in 0c2063f

description:

Description can't be empty

@stdevMac
Copy link
Member

stdevMac commented Feb 27, 2019 •
edited
Loading

Add response 200 like this, becouse this way looks like any response is an generic error:

responses:
  '200':
    description: Some description, not empty
  default:
    ....

This here:

skyxcommons/AdrianPaez_spec.yml

Line 120 in 0c2063f

responses:

and
https://github.com/uhsimelo/skyxcommons/blob/0c2063f4cae63ec91125cec03e660dd63b99beae/AdrianPaez_spec.yml#L101

@stdevMac
Copy link
Member

@AdrianPaez Please add Some description, edit PR
#25 (comment)

@stdevMac stdevMac self-requested a review February 27, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdevMac stdevMac Awaiting requested review from stdevMac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantpaez @stdevMac