Implement API manager #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
hatchan
force-pushed
the
tauri-api
branch
5 times, most recently
from
15751b5 to
6acd6f4
Compare
hatchan
force-pushed
the
tauri-api
branch
2 times, most recently
from
86c1ab1 to
76639ab
Compare
Use Option<T> functions instead of doing it manually
Move LibSqlStore and InMemoryEvents to fpx
Rename CI from build to build_cli
Fix issue with duplicate recent workspace entries
Previously there was a possibility that start would be called twice and two processes would be started, but only one PID would be stored Add more docs, logs, etc
Use 8788 as api port
I've removed the TODO's, but they are still applicable. They are part of another issue. Thanks for the headsup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows fpx-app to startup a API whenever a workspace is opened, and stop the API when the workspace is closed.
There are currently two implementations: One that uses the current TS API and starts it by starting processes and managing these. There is also a implementation that uses the Rust API which get started as part of the fpx-app process itself.
Currently the TS implementation is used by default. The Rust API can be used by building the fpx-app with the
fpx-apifeature flag. Example:cargo tauri dev -f fpx-api.Other changes:
fpx-clitofpxResolves: FP-4177, FP-4184