Zod schema generator with working schema references #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
stephlow
changed the title
stephlow
requested review from
flenter and
hatchan
and removed request for
a team
flenter
approved these changes
Oct 22, 2024
oscarvz
approved these changes
Oct 23, 2024
hatchan
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to the schema generator. Couldn't properly configure the related reference schemas in the previous version, which this one fixes.
This one doesn't have support for adding doc comments to the
.describemethod on zod schemas, but we don't really use that atm anywayI added a polyfill for
memoizeOne, which the underlying rust library adds to the generated schemas. The actual library doesn't play well with our current ts setup so I just replaced it with a simple function call, no actual memoization for now