App routes file source tree using code analysis #375
Conversation
And split into multiple files Also: introduce a SearchContext that contains most important references (like the server, program, etc)
Also do a minor refactor
And fix app.route() where the route was imported (and aliased) from another module
|
I've tweaked the UI a bit in order to improve the looks: |
|
Looks great! How difficult would it be to fix the keyboard navigation? |
|
I have fixed the issue where the currently active route is highlighted (though not in a pretty way). And I'm now looking at the selection. It is a bit more involved because keyboard navigation also can also go to the custom routes |
|
sounds good! Keyboard Navigation would still be a nice to have for today's release 🚀 |
|
I've got a basic version of it working. However when switching between different views, all collapsed/expanded state gets reset and also: keyboard navigation does not take into consideration that you can collapse tree items. So it could benefit from a refactor |
flenter
force-pushed
the
source-tree
branch
2 times, most recently
from
7fc61ff to
4106965
Compare
And fix filtered keyboard navigation
| @@ -47,7 +47,7 @@ export const ProbedRouteSchema = z.object({ | |||
| currentlyRegistered: z.boolean(), | |||
| registrationOrder: z.number().default(-1), | |||
| routeOrigin: z.enum(["discovered", "custom", "open_api"]), | |||
| openApiSpec: z.string().optional(), | |||
| openApiSpec: z.string().nullish().optional(), | |||
There was a problem hiding this comment.
This the second definition of the app route we should investigate if we can delete one of them. But given the deadline, i haven't done this for this PR
|
Keyboard navigation should be fixed now |
Index based keyboard navigation is broken atm in the file treeExpanded example:
Screen.Recording.2024-11-26.at.14.18.48.mov
Single file example:
Screen.Recording.2024-11-26.at.14.17.45.mov