Various Fixes: Websocket heartbeat, historical request sorting, et al #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
brettimus
force-pushed
the
various-websocket-fixes
branch
2 times, most recently
from
a1669ed to
f85b0f2
Compare
brettimus
commented
Dec 10, 2024
| @@ -194,6 +194,19 @@ export function useRequestorHistory() { | |||
| })), | |||
| ), | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
this function badly needs a refactor, but i have other things to do this week 😬
brettimus
changed the title
mies
approved these changes
Dec 10, 2024
flenter
approved these changes
Dec 11, 2024
brettimus
force-pushed
the
various-websocket-fixes
branch
from
aa33804 to
5c67a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
RefactorloadHistoricalRequestDescription
This PR does a few things:
pongresponses for the heartbeat coming from the Studio frontendHeartbeat
Our
pongresponses topingmessages were never being sent down the wire, which caused theuseRealtimeServicehook to think that the websocket connection was no longer open after a minute.Changing the studio api's websocket server to treat
pings as regular messages resolved the issue.I kept the old code as a comment with an explainer that it was not working properly.
Load request bodies from historical requests
When poking around with the new example api, I hit a case where
loadHistoricalRequestwas not setting the body for certain requests from the history. I had to make an ugly function uglier, but resolve this issue by copy-pasting code ((working on a refactor now))Fix Default Studio Api Database Timestamps
CURRENT_TIMESTAMPin sqlite was not iso8601. Changed the db schema default values to fix that, since sometimes we were adding iso timestamps manually to certain records, and then having a mix of timestamps messed up sorting in the UINew Example: Telegram bot
Why?
I wanted a webhook related example in our monorepo to test possible connection interruptions to webhonc.