Merge pull request #22 from joostbaptist/2.1.4-signature-fix

Fix detach method when called without IDs

src/Relations/BelongsToManyCustom.php

@@ -32,8 +32,12 @@ public function attach($ids, array $attributes = [], $touch = true)
  * @param bool $touch
  * @return int
  */
- public function detach($ids = [], $touch = true)
+ public function detach($ids = null, $touch = true)
  {
+ if (is_null($ids)) {
+ $ids = $this->query->pluck($this->query->qualifyColumn($this->relatedKey))->toArray();
+ }
+
  list($idsOnly) = $this->getIdsWithAttributes($ids);
 
  $this->parent->fireModelEvent('pivotDetaching', true, $this->getRelationName(), $idsOnly);

tests/PivotEventTraitTest.php

@@ -164,6 +164,21 @@ public function test_detach_collection()
  $this->check_variables(0, [1, 2]);
  }
 
+ public function test_detach_null()
+ {
+ $this->startListening();
+ $user = User::find(1);
+ $user->roles()->attach([1, 2 ,3]);
+ $this->assertEquals(3, \DB::table('role_user')->count());
+
+ $this->startListening();
+ $user->roles()->detach();
+
+ $this->assertEquals(0, \DB::table('role_user')->count());
+ $this->check_events(['eloquent.pivotDetaching: ' . User::class, 'eloquent.pivotDetached: ' . User::class]);
+ $this->check_variables(0, [1, 2, 3]);
+ }
+
  public function test_update()
  {
  $this->startListening();