Get all IDs when detaching without arguments

fico7489 · Feb 22, 2018 · d7608aa · d7608aa
1 parent 0e8470c
commit d7608aa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Relations/BelongsToManyCustom.php b/src/Relations/BelongsToManyCustom.php
@@ -34,6 +34,10 @@ public function attach($ids, array $attributes = [], $touch = true)
      */
     public function detach($ids = null, $touch = true)
     {
+        if (is_null($ids)) {
+            $ids = $this->query->pluck($this->query->qualifyColumn('id'))->toArray();
+        }
+
         list($idsOnly) = $this->getIdsWithAttributes($ids);
 
         $this->parent->fireModelEvent('pivotDetaching', true, $this->getRelationName(), $idsOnly);

diff --git a/tests/PivotEventTraitTest.php b/tests/PivotEventTraitTest.php
@@ -176,7 +176,7 @@ public function test_detach_null()
 
         $this->assertEquals(0, \DB::table('role_user')->count());
         $this->check_events(['eloquent.pivotDetaching: ' . User::class, 'eloquent.pivotDetached: ' . User::class]);
-        $this->check_variables(0, []);
+        $this->check_variables(0, [1, 2, 3]);
     }
 
     public function test_update()