-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated: Repeater's grid()
method can except closure as parameter
#14630
Open
tjodalv
wants to merge
17
commits into
filamentphp:4.x
Choose a base branch
from
tjodalv:feat/make-repeater-grid-accept-closure
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updated: Repeater's grid()
method can except closure as parameter
#14630
tjodalv
wants to merge
17
commits into
filamentphp:4.x
from
tjodalv:feat/make-repeater-grid-accept-closure
+52
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will make possible to set Repeater::grid('auto').
Add console command optimization in FilamentServiceProvider
…rt-null-bugs fix: Import/export null bugs
Update European Portuguese Translation
Update European Portuguese Translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up of #14553
Hi! Thanks for the feedback, and apologies for any oversight on our end regarding the contribution guidelines. I've reviewed the notes, and I've created a new pull request where:
->grid()
function has been adjusted so that calling->grid()
multiple times merges onto the array, maintaining the original behavior. Additionally,->grid()
now accepts a closure. Closure will be executed last allowing it to override any breakpoint value that is being set previously.I'm looking forward to any further feedback, and thank you for considering this improvement for v4!
Functional changes
composer cs
command.