Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic scrolling of wizard steps #14826

Open
wants to merge 4 commits into
base: 3.x
Choose a base branch
from
Open

Add automatic scrolling of wizard steps #14826

wants to merge 4 commits into from

Conversation

austincarpenter
Copy link
Contributor

Description

This PR ensures the wizard scrolls the current step into view when moving between steps.

#14665

Visual changes

scroll-wizard-steps.mp4

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@austincarpenter austincarpenter changed the title Add x-ref and scroll to current header step Add automatic scrolling of wizard steps Nov 18, 2024
zepfietje
zepfietje requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@zepfietje zepfietje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this UX improvement, @austincarpenter! 😄

packages/forms/resources/views/components/wizard.blade.php Outdated Show resolved Hide resolved
@zepfietje zepfietje added enhancement New feature or request ux labels Nov 19, 2024
@zepfietje zepfietje linked an issue Nov 19, 2024 that may be closed by this pull request
Wizard header auto horizontal scroll #14665
Open
zepfietje
zepfietje approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@zepfietje zepfietje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR locally and simplified the scroll method since scrolling the step into view no longer requires the wizard itself to be scrolled into view.

Looks good to me! 👌

@zepfietje
Copy link
Member

Ready for merge, @danharrin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepfietje zepfietje zepfietje approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ux
Projects
Roadmap
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wizard header auto horizontal scroll
2 participants
@austincarpenter @zepfietje