-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sync connection support for ExportAction
#14854
base: 3.x
Are you sure you want to change the base?
Improve sync connection support for ExportAction
#14854
Conversation
ExportAction
ExportAction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, @ralphjsmit!
I agree there's a strong use case for this (also from personal experience). Thanks for improving the UX around those exports. 😊
Co-authored-by: Zep Fietje <hey@zepfietje.com>
Thanks! Yeah I also like the exports feature, so glad to add some improvements based on real-life cases. The biggest thing yet I would really wish for on exports is the ability to format (Excel) cells to their native type (like integer, money), text formatting and set column widths. But that unfortunately seems very difficult/unsupported on the OpenSpout package... Update: it seems to be possible to style on row-level already, but not yet on the individual/cell column level. Though I dived a bit more and OpenSpout does seem to support passing individual Style objects to individual Cells, so perhaps if we can re-work our logic a little that could work out... 🤔 Update: leaving this here for later reference: https://github.com/openspout/openspout/blob/4.x/src/Writer/XLSX/Manager/Style/StyleRegistry.php |
Interesting! Keep us posted when you've experimented with that. 😄 |
ExportAction
ExportAction
It can be very helpful to run an export on the sync queue if it does not take too long and then immediately display a notification to download it, instead of needing to wait on a job being picked up by a queue and then monitoring the notifications bell icon. In my tests running an export in sync was even quicker than waiting for an (empty) queue to pick it, process all the individual batch parts and then send back to the user. Particularly for less tech-savvy users this is not intuitive.
The ExportAction can already run on the
sync
connection, but this PR improves support for that by removing the first export started notification and changing the export completed notification to a persistent in-page notification.Thanks!