Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rely on Laravel's default job retry settings for Imports/Exports #14856

Open
wants to merge 6 commits into
base: 3.x
Choose a base branch
from

Conversation

ahinkle
Copy link
Contributor

@ahinkle ahinkle commented Nov 20, 2024

Description

This PR addresses an issue with the default retry behavior for failed imports, which can lead to unintended costs and resource usage. Specifically, the default behavior allows a bad import to continuously retry for 24 hours, potentially resulting in increased expenses due to services like AWS SQS and exception logging.

While the 24-hour retry window was designed to account for temporary issues like a database outage, it is more common for failures to result from code bugs or invalid data. Reducing the retry duration prevents these issues from escalating into excessive costs while still allowing jobs to retry a reasonable number of times.

We retain the existing method for those who prefer it while updating the default to align with your application (or Laravel's) defaults.

Fixes #13113 , #10816

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@ahinkle ahinkle changed the title Fix: Rely on Laravel's default job retry settings Fix: Rely on Laravel's default job retry settings for Imports/Exports Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant