Skip to content

Commit

Permalink
doc: make it clear InlineBuilder isn't recommended
Browse files Browse the repository at this point in the history
i.e. don't copypasta this for your filecoin deal prep
  • Loading branch information
rvagg authored and jacobheun committed Nov 24, 2022
1 parent 9b370fa commit 0412500
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions car/car_offset_writer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ func DAGImport(dserv format.DAGService, fi io.Reader) (format.Node, error) {
Maxlinks: 1024,
RawLeaves: true,

// NOTE: InlineBuilder not recommended, we are using this to test identity CIDs
CidBuilder: cidutil.InlineBuilder{
Builder: prefix,
Limit: 32,
Expand Down
2 changes: 1 addition & 1 deletion itests/framework/framework.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ import (
unixfile "github.com/ipfs/go-unixfs/file"
"github.com/ipld/go-car"
"github.com/libp2p/go-libp2p"
"github.com/libp2p/go-libp2p-core/host"
"github.com/libp2p/go-libp2p/core/host"
"github.com/multiformats/go-multihash"
"github.com/stretchr/testify/require"
"golang.org/x/sync/errgroup"
Expand Down
1 change: 1 addition & 0 deletions testutil/car.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ func WriteUnixfsDAGTo(path string, into ipldformat.DAGService) (cid.Cid, error)
params := ihelper.DagBuilderParams{
Maxlinks: unixfsLinksPerLevel,
RawLeaves: true,
// NOTE: InlineBuilder not recommended, we are using this to test identity CIDs
CidBuilder: cidutil.InlineBuilder{
Builder: prefix,
Limit: 126,
Expand Down
1 change: 1 addition & 0 deletions transport/httptransport/http_transport_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@ func dagImport(dserv format.DAGService, fi io.Reader) (format.Node, error) {
Maxlinks: 1024,
RawLeaves: true,

// NOTE: InlineBuilder not recommended, we are using this to test identity CIDs
CidBuilder: cidutil.InlineBuilder{
Builder: prefix,
Limit: 32,
Expand Down

0 comments on commit 0412500

Please sign in to comment.