Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support peer filtering for booster-bitswap for endpoint #994

Closed
wants to merge 3 commits into from
Closed

Support peer filtering for booster-bitswap for endpoint #994

wants to merge 3 commits into from

Conversation

hannahhoward
Copy link
Collaborator

Goals

fix #847 start on #954

Implementation

  • Extract periodic fetching logic from block filter to multifilter class
  • Implement peer filter based on specs from @s0nik42
  • Add peer filter endpoint as cli url

For discussion

  • Pending further discussion of additional retrieval configs with @s0nik42
  • At somepoint booster bitswap will need a config file
  • Otherwise GTG I think

@hannahhoward hannahhoward requested a review from dirkmc November 23, 2022 03:27
dirkmc
dirkmc approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, but overall LGTM 👍

cmd/booster-bitswap/filters/filters.go Outdated Show resolved Hide resolved
cmd/booster-bitswap/filters/filters.go Show resolved Hide resolved
cmd/booster-bitswap/filters/filters.go Outdated Show resolved Hide resolved
cmd/booster-bitswap/filters/filters.go Outdated
cfgDir string
filters []*filter
clock clock.Clock
onTimerSet func()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
onTimerSet func()
onTick func()

cmd/booster-bitswap/server.go Outdated Show resolved Hide resolved
@dirkmc
Copy link
Contributor

dirkmc commented Nov 23, 2022

Please test with a local devnet before merging

This was referenced Nov 30, 2022
Closed
Closed
hannahhoward and others added 3 commits December 1, 2022 19:09
@hannahhoward
feat(filters): add peer filter
be79b05 
add peer filter parsing and processing and test combined logic
@hannahhoward @dirkmc
Apply suggestions from code review
3ab025d 
Co-authored-by: dirkmc <dirkmdev@gmail.com>
@hannahhoward
refactor(filters): rename onTimerSet -> onTick
044ddd7
@hannahhoward hannahhoward mentioned this pull request Dec 5, 2022
Merged
@hannahhoward
Copy link
Collaborator Author

closing in favor of #1030

@nonsense nonsense deleted the feat/peer-deny-list branch January 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

booster-bitswap add ability to dynamically add Peer ID to denylist
2 participants
@hannahhoward @dirkmc