Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to boxo #792

Merged
merged 3 commits into from
Jun 14, 2023
Merged

chore: migrate to boxo #792

merged 3 commits into from
Jun 14, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented May 25, 2023

This migrates everything except the go-car librairy: ipfs/boxo#218 (comment)

@Jorropo
Copy link
Contributor Author

Jorropo commented May 25, 2023

DO NOT MERGE UNTIL ipfs/boxo#291 is fixed (and this PR is bumped to a version of boxo or go-car where this is fixed)

@Jorropo Jorropo marked this pull request as draft May 25, 2023 15:11
@aschmahmann aschmahmann force-pushed the boxo branch 3 times, most recently from 43cfd96 to d71c842 Compare June 1, 2023 17:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #792 (9858343) into master (62ac6f5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   58.04%   58.04%           
=======================================
  Files          64       64           
  Lines        5373     5373           
=======================================
  Hits         3118     3118           
  Misses       1924     1924           
  Partials      331      331           
Impacted Files Coverage Δ
discovery/impl/local.go 62.07% <ø> (ø)
retrievalmarket/impl/client.go 72.05% <ø> (ø)
retrievalmarket/impl/dtutils/dtutils.go 78.31% <ø> (ø)
retrievalmarket/impl/lazyblockstore.go 51.17% <ø> (ø)
retrievalmarket/impl/provider_environments.go 62.07% <ø> (ø)
storagemarket/impl/client_environments.go 0.00% <ø> (ø)
storagemarket/impl/clientutils/clientutils.go 40.55% <ø> (ø)
storagemarket/impl/dtutils/dtutils.go 68.82% <ø> (ø)
storagemarket/impl/provider_environments.go 10.38% <ø> (ø)
stores/dagstore.go 0.00% <ø> (ø)
... and 3 more

@ZenGround0
Copy link
Contributor

I don't have authorization here but LGTM

Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, conditional on updating all the dependencies to release versions.

@Jorropo Jorropo marked this pull request as ready for review June 8, 2023 10:39
This migrates everything except the `go-car` librairy: ipfs/boxo#218 (comment)
@hannahhoward hannahhoward merged commit fcd12c8 into filecoin-project:master Jun 14, 2023
hannahhoward added a commit that referenced this pull request Jun 16, 2023
* chore: migrate to boxo

This migrates everything except the `go-car` librairy: ipfs/boxo#218 (comment)

* chore(deps): update to boxo v0.10.0

* chore(deps): update to tagged go-car

---------

Co-authored-by: hannahhoward <hannah@hannahhoward.net>
hannahhoward added a commit that referenced this pull request Jun 17, 2023
* chore: migrate to boxo

This migrates everything except the `go-car` librairy: ipfs/boxo#218 (comment)

* chore(deps): update to boxo v0.10.0

* chore(deps): update to tagged go-car

---------

Co-authored-by: hannahhoward <hannah@hannahhoward.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants