-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX Streamline] OpenRPC definitions are inaccurate #12164
Milestone
Comments
There may be other bugs in the definitions - forest has put effort into emitting correct schemas which may be a useful reference |
Great! Thanks for this one. What about the use of |
Yep, forest represents them correctly, also respecting the quirk that empty arrays are serialized as {
"type": [
"array",
"null"
],
"items": {
"$ref": "#/components/schemas/Cid"
},
"components": {
"schemas": {
"Cid": {
"type": "object",
"required": [
"/"
],
"properties": {
"/": {
"type": "string"
}
}
}
}
}
} |
rjan90
changed the title
OpenRPC definitions are inaccurate
[DX Streamline] OpenRPC definitions are inaccurate
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Latest release
, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Lotus component
Lotus Version
Repro Steps
No response
Describe the Bug
https://github.com/filecoin-project/lotus/blob/36d96342c36186ab15417b53511dce94b66ae089/build/openrpc/full.json#L71-L91
The schema for, e.g
cid
is wrong - it's notit's
(as expected and emitted by lotus)
Logging Information
The text was updated successfully, but these errors were encountered: