Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio forest compat #12038

Closed
wants to merge 1 commit into from
Closed

feat: curio forest compat #12038

wants to merge 1 commit into from

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented May 23, 2024

Related Issues

Limited the API set in Curio to this list.

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus snadrus requested a review from LexLuthr May 23, 2024 22:26
@snadrus
Copy link
Contributor Author

snadrus commented May 23, 2024

Along with the given list, Curio also needed:

  • StateMinerActiveSectors
  • MpoolPushMessage
  • StateSectorPartition
    Do we need to tell Forest about this? @LexLuthr

Copy link

github-actions bot commented May 23, 2024

All checks have completed

❌ Failed Test / Test (itest-api) (pull_request)
❌ Failed Test / Test (itest-batch_deal) (pull_request)
❌ Failed Test / Test (itest-cli) (pull_request)
❌ Failed Test / Test (itest-curio) (pull_request)
❌ Failed Test / Test (itest-deadlines) (pull_request)
❌ Failed Test / Test (itest-deals) (pull_request)
❌ Failed Test / Test (itest-deals_512mb) (pull_request)
❌ Failed Test / Test (itest-deals_anycid) (pull_request)
❌ Failed Test / Test (itest-deals_concurrent) (pull_request)
❌ Failed Test / Test (itest-deals_invalid_utf8_label) (pull_request)
❌ Failed Test / Test (itest-deals_max_staging_deals) (pull_request)
❌ Failed Test / Test (itest-deals_offline) (pull_request)
❌ Failed Test / Test (itest-deals_padding) (pull_request)
❌ Failed Test / Test (itest-deals_partial_retrieval) (pull_request)
❌ Failed Test / Test (itest-deals_partial_retrieval_dm-level) (pull_request)
❌ Failed Test / Test (itest-deals_power) (pull_request)
❌ Failed Test / Test (itest-deals_pricing) (pull_request)
❌ Failed Test / Test (itest-deals_publish) (pull_request)
❌ Failed Test / Test (itest-deals_remote_retrieval) (pull_request)
❌ Failed Test / Test (itest-deals_retry_deal_no_funds) (pull_request)
❌ Failed Test / Test (itest-direct_data_onboard) (pull_request)
❌ Failed Test / Test (itest-direct_data_onboard_verified) (pull_request)
❌ Failed Test / Test (itest-dup_mpool_messages) (pull_request)
❌ Failed Test / Test (itest-eth_account_abstraction) (pull_request)
❌ Failed Test / Test (itest-eth_api) (pull_request)
❌ Failed Test / Test (itest-eth_balance) (pull_request)
❌ Failed Test / Test (itest-eth_block_hash) (pull_request)
❌ Failed Test / Test (itest-eth_bytecode) (pull_request)
❌ Failed Test / Test (itest-eth_config) (pull_request)
❌ Failed Test / Test (itest-eth_conformance) (pull_request)
❌ Failed Test / Test (itest-eth_deploy) (pull_request)
❌ Failed Test / Test (itest-eth_fee_history) (pull_request)
❌ Failed Test / Test (itest-eth_filter) (pull_request)
❌ Failed Test / Test (itest-eth_hash_lookup) (pull_request)
❌ Failed Test / Test (itest-eth_transactions) (pull_request)
❌ Failed Test / Test (itest-fevm) (pull_request)
❌ Failed Test / Test (itest-fevm_address) (pull_request)
❌ Failed Test / Test (itest-fevm_events) (pull_request)
❌ Failed Test / Test (itest-gas_estimation) (pull_request)
❌ Failed Test / Test (itest-gateway) (pull_request)
❌ Failed Test / Test (itest-get_messages_in_ts) (pull_request)
❌ Failed Test / Test (itest-harmonydb) (pull_request)
❌ Failed Test / Test (itest-harmonytask) (pull_request)
❌ Failed Test / Test (itest-lite_migration) (pull_request)
❌ Failed Test / Test (itest-lookup_robust_address) (pull_request)
❌ Failed Test / Test (itest-mempool) (pull_request)
❌ Failed Test / Test (itest-migration) (pull_request)
❌ Failed Test / Test (itest-mpool_msg_uuid) (pull_request)
❌ Failed Test / Test (itest-mpool_push_with_uuid) (pull_request)
❌ Failed Test / Test (itest-msgindex) (pull_request)
❌ Failed Test / Test (itest-multisig) (pull_request)
❌ Failed Test / Test (itest-net) (pull_request)
❌ Failed Test / Test (itest-nonce) (pull_request)
❌ Failed Test / Test (itest-path_detach_redeclare) (pull_request)
❌ Failed Test / Test (itest-path_type_filters) (pull_request)
❌ Failed Test / Test (itest-paych_api) (pull_request)
❌ Failed Test / Test (itest-paych_cli) (pull_request)
❌ Failed Test / Test (itest-pending_deal_allocation) (pull_request)
❌ Failed Test / Test (itest-remove_verifreg_datacap) (pull_request)
❌ Failed Test / Test (itest-sealing_resources) (pull_request)
❌ Failed Test / Test (itest-sector_finalize_early) (pull_request)
❌ Failed Test / Test (itest-sector_import_full) (pull_request)
❌ Failed Test / Test (itest-sector_import_simple) (pull_request)
❌ Failed Test / Test (itest-sector_miner_collateral) (pull_request)
❌ Failed Test / Test (itest-sector_numassign) (pull_request)
❌ Failed Test / Test (itest-sector_pledge) (pull_request)
❌ Failed Test / Test (itest-sector_terminate) (pull_request)
❌ Failed Test / Test (itest-sector_unseal) (pull_request)
❌ Failed Test / Test (itest-self_sent_txn) (pull_request)
❌ Failed Test / Test (itest-splitstore) (pull_request)
❌ Failed Test / Test (itest-supply) (pull_request)
❌ Failed Test / Test (itest-verifreg) (pull_request)
❌ Failed Test / Test (itest-wdpost) (pull_request)
❌ Failed Test / Test (itest-wdpost_config) (pull_request)
❌ Failed Test / Test (itest-wdpost_dispute) (pull_request)
❌ Failed Test / Test (itest-wdpost_no_miner_storage) (pull_request)
❌ Failed Test / Test (itest-wdpost_worker_config) (pull_request)
❌ Failed Test / Test (itest-worker) (pull_request)
❌ Failed Test / Test (itest-worker_upgrade) (pull_request)
❌ Failed Test / Test (unit-cli) (pull_request)

Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a usage in chain-connectivity.mjs as well to track chain sync. We might need to modify that to work individually with node types. We can probably handle that in the same PR where we add the Forest integration.

@@ -147,7 +148,7 @@ func StorageNetworkName(ctx helpers.MetricsCtx, a v1api.FullNode) (dtypes.Networ
return a.StateNetworkName(ctx)
}

func SealProofType(maddr dtypes.MinerAddress, fnapi v1api.FullNode) (abi.RegisteredSealProof, error) {
func SealProofType(maddr dtypes.MinerAddress, fnapi daemonapi.Daemon) (abi.RegisteredSealProof, error) {
Copy link
Contributor

@LexLuthr LexLuthr May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's copy over this function to Curio deps to fix the failing tests. I think that's the cheapest solution here instead of a complicated FX dependency fix.

@LexLuthr
Copy link
Contributor

Closing as this has been ported.

@LexLuthr LexLuthr closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants