feat: automate use of mkreleaselog #12199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what the outputs looks like: filecoin-project/go-state-types (v0.14.0-rc1 -> v0.14.0-rc2)Others
Contributors
|
rvagg
reviewed
Jul 11, 2024
Comment on lines
+180
to
+182
| if [[ -z "$insertion_point" ]]; then | ||
| cat release-notes.md >> CHANGELOG.md | ||
| else |
There was a problem hiding this comment.
I think this case might be better to fatally fail with than append to the tail
rvagg
reviewed
Jul 11, 2024
Comment on lines
+131
to
+132
| new_features=$(echo "$content" | grep -i '^- feat:' || true) | ||
| improvements=$(echo "$content" | grep -i '^- fix:' || true) |
There was a problem hiding this comment.
it would be awesome to fit breaking changes into this too (feedback from @rjan90 @aarshkshah1992 @ZenGround0 would be good on whether they're comfortable with full CC style would be good):
Suggested change
| new_features=$(echo "$content" | grep -i '^- feat:' || true) | |
| improvements=$(echo "$content" | grep -i '^- fix:' || true) | |
| new_features=$(echo "$content" | grep -i '^- feat:' || true) | |
| improvements=$(echo "$content" | grep -i '^- fix:' || true) | |
| breaking_changes=$(echo "$content" | grep -iE '^- [^:]+!:' || true) |
rvagg
reviewed
Jul 11, 2024
| new_features=$(echo "$content" | grep -i '^- feat:' || true) | ||
| improvements=$(echo "$content" | grep -i '^- fix:' || true) | ||
|
|
||
| used=$(echo -e "$new_features\n$improvements") |
There was a problem hiding this comment.
Suggested change
| used=$(echo -e "$new_features\n$improvements") | |
| used=$(echo -e "$new_features\n$improvements\n$breaking_changes") |
rvagg
reviewed
Jul 11, 2024
| echo "$new_features" | ||
| echo | ||
| fi | ||
|
|
There was a problem hiding this comment.
Suggested change
| if [[ -n "$breaking_changes" ]]; then | |
| echo "### Breaking Changes" | |
| echo | |
| echo "$breaking_changes" | |
| echo | |
| fi | |
|
#12096 now supersedes the exploration performed here. TLDR; we found it to be more efficient to combine the outputs of mkreleaselog + CHANGELOG.md entries to create proposed released notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fix #12162
Proposed Changes
Additional Info
💣 Setting this into draft and targeting @galargh's branch for now so we can sync on the work
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps[skip changelog]to the PR titleskip-changelogto the PR