Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

improve error classification #165

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

AmeanAsad
Copy link
Contributor

Changes

  • Network errors are only applicable when there isn't an http status received.
  • If an error is not a network error or a verification error, it gets submitted as "otherError" to the Saturn log ingestor.

@AmeanAsad AmeanAsad requested review from willscott and guanzo October 2, 2023 21:01
@AmeanAsad AmeanAsad merged commit 1015a7f into aa/test-simulator Oct 3, 2023
16 checks passed
@AmeanAsad AmeanAsad deleted the enhancement/error-classification branch October 3, 2023 13:09
willscott added a commit that referenced this pull request Oct 10, 2023
* feat: modify pool tests

* fix: top n node selection from heap

* feat: add more comprehensive tests

* enhancement: add refresh no to tests

* go fmt

* remove unused metrics

* put back trace

* response size does not include header

* reset retry counter only if progress is made

* update go-car

* dont drain response body

* send verification errors to Saturn

* pool tier promotion

* otel and send trace id to Saturn

* stabilize dynamics tests

* mirroring parallel

* pool-target-size through config to better test dynamics

* down to flakiness

* add substitution (rough)

* use new orchestrator API

* fix: top N selection

* enhancement: increase test size

* feat: Add tests for affinity

* test cache affinity

* test cache affinity

* remove assert

* fix test

* address review

* feat: port compliance cids

* fix: remove unused code

* modify harness

* feat: add core attr to trace span

* fix CI

* improve error classification (#165)

---------

Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
Co-authored-by: Will Scott <will.scott@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants