Fix: Fixed an issue with the 'Run with PowerShell' action not supporting files with spaces in their names #16455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 0x5bfa <62196528+0x5bfa@users.noreply.github.com>
|
Please provide steps you validated this change. |
|
Hang on |
yaira2
changed the title
|
It looks like the issue is still present |
|
Yeah I know I'm working on it |
|
Yes I'm aware, I'll try again with it a bit later |
|
Sorry for opening the pr early before finding out whether the issue is fixed it's just the only way I can get the package is from the ci run. |
|
That's fine, I'll wait until it's ready. |
|
There's still something else I haven't tried but it's unlikely to work. |
|
This should fix the issue return Win32Helper.RunPowershellCommandAsync($"\"{context.ShellPage?.SlimContentPage?.SelectedItem?.ItemPath}\"", PowerShellExecutionOptions.None); |
That didn't work for me, see |
|
I forgot to add a space to the file name when I tested 😀 |
|
This should work (I tested a file with a space this time). return Win32Helper.RunPowershellCommandAsync($"& '{context.ShellPage?.SlimContentPage?.SelectedItem?.ItemPath}'", PowerShellExecutionOptions.None); |
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
yaira2
changed the title
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.