Fixed all warnings which are fixable (#25)

* Fixed all warnings which are fixable * change modifier open to public
filestack · Nov 18, 2024 · f603151 · f603151
1 parent 19db447
commit f603151
Show file tree

Hide file tree

Showing 10 changed files with 11 additions and 11 deletions.
diff --git a/Sources/FilestackSDK/Internal/Extensions/Data+base64MD5Digest.swift b/Sources/FilestackSDK/Internal/Extensions/Data+base64MD5Digest.swift
@@ -15,7 +15,7 @@ extension Data {
         return Data((withUnsafeBytes { byte -> [UInt8] in
             var digest = [UInt8](repeating: 0, count: Int(CC_MD5_DIGEST_LENGTH))
 
-            CC_MD5(byte.baseAddress, CC_LONG(count), &digest)
+            CC_SHA256(byte.baseAddress, CC_LONG(count), &digest)
 
             return digest
         })).base64EncodedString()

diff --git a/Sources/FilestackSDK/Internal/Operations/CommitPartUploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/CommitPartUploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class CommitPartUploadOperation: BaseOperation<HTTPURLResponse> {
+class CommitPartUploadOperation: BaseOperation<HTTPURLResponse>, @unchecked Sendable {
     // MARK: - Private Properties
 
     private let descriptor: UploadDescriptor

diff --git a/Sources/FilestackSDK/Internal/Operations/CompleteUploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/CompleteUploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class CompleteUploadOperation: BaseOperation<JSONResponse> {
+class CompleteUploadOperation: BaseOperation<JSONResponse>, @unchecked Sendable {
     // MARK: - Private Properties
 
     private let partsAndEtags: [Int: String]

diff --git a/Sources/FilestackSDK/Internal/Operations/StartUploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/StartUploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class StartUploadOperation: BaseOperation<UploadDescriptor> {
+class StartUploadOperation: BaseOperation<UploadDescriptor>, @unchecked Sendable {
     // MARK: - Private Properties
 
     private let config: Config

diff --git a/Sources/FilestackSDK/Internal/Operations/SubmitChunkUploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/SubmitChunkUploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class SubmitChunkUploadOperation: BaseOperation<HTTPURLResponse> {
+class SubmitChunkUploadOperation: BaseOperation<HTTPURLResponse>, @unchecked Sendable {
     // MARK: - Internal Properties
 
     // Part offset

diff --git a/Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class SubmitPartIntelligentUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation {
+class SubmitPartIntelligentUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation, @unchecked Sendable {
     // MARK: - Internal Properties
 
     let number: Int

diff --git a/Sources/FilestackSDK/Internal/Operations/SubmitPartRegularUploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/SubmitPartRegularUploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class SubmitPartRegularUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation {
+class SubmitPartRegularUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation, @unchecked Sendable {
     // MARK: - Internal Properties
 
     let number: Int

diff --git a/Sources/FilestackSDK/Internal/Operations/SubmitPartsUploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/SubmitPartsUploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class SubmitPartsUploadOperation: BaseOperation<[Int: String]> {
+class SubmitPartsUploadOperation: BaseOperation<[Int: String]>, @unchecked Sendable {
     // MARK: - Internal Properties
 
     let descriptor: UploadDescriptor

diff --git a/Sources/FilestackSDK/Internal/Operations/UploadOperation.swift b/Sources/FilestackSDK/Internal/Operations/UploadOperation.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-class UploadOperation: BaseOperation<JSONResponse> {
+class UploadOperation: BaseOperation<JSONResponse>, @unchecked Sendable {
     // MARK: - Internal Properties
 
     private(set) lazy var progress: Progress = {

diff --git a/Sources/FilestackSDK/Public/Operations/BaseOperation.swift b/Sources/FilestackSDK/Public/Operations/BaseOperation.swift
@@ -17,7 +17,7 @@ import Foundation
 /// - An executing operation will return `isExecuting` true.
 /// - A finished operation will return `isFinished` true.
 /// - A cancelled operation will return `isCancelled` true.
-open class BaseOperation<Success>: Operation {
+open class BaseOperation<Success>: Operation, @unchecked Sendable {
     public typealias Result = Swift.Result<Success, Error>
 
     // MARK: - Private Properties
@@ -81,7 +81,7 @@ open class BaseOperation<Success>: Operation {
 
 extension BaseOperation {
     /// Returns the result of operation.
-    open private(set) var result: Result {
+    public private(set) var result: Result {
         get { lockQueue.sync { _result } }
         set { lockQueue.sync { _result = newValue } }
     }