Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mod #56

Merged
merged 3 commits into from
May 20, 2024
Merged

fix mod #56

merged 3 commits into from
May 20, 2024

Conversation

willow-ahrens
Copy link
Collaborator

@willow-ahrens willow-ahrens commented May 17, 2024 •
edited
Loading

fixes #53

hameerabbasi
hameerabbasi approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the lightning quick fix, @willow-ahrens!

@hameerabbasi
Copy link
Collaborator

Minor comment: Could we add a regression test?

@willow-ahrens
Copy link
Collaborator Author

Is this not tested in the array api tests?

@willow-ahrens
Copy link
Collaborator Author

I'll be fairly busy the next couple of weeks, so I'd appreciate help on these tests.

@mtsokol mtsokol merged commit 2567a83 into main May 20, 2024
5 checks passed
@mtsokol mtsokol deleted the wma/mod_2 branch May 20, 2024 09:58
@mtsokol
Copy link
Collaborator

mtsokol commented May 20, 2024

I added a regression test. Thanks @willow-ahrens!

@mtsokol mtsokol added the bug Something isn't working label May 20, 2024
@willow-ahrens willow-ahrens mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi approved these changes

@mtsokol mtsokol mtsokol approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__mod__ can return incorrect results
3 participants
@willow-ahrens @hameerabbasi @mtsokol