Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed compute_clip_image_embedding overloads #451

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

Laurent2916
Copy link
Member

@Laurent2916 Laurent2916 commented Sep 26, 2024

The compute_clip_image_embedding overloads don't seem to have a purpose, I removed them and tweaked the main docstring a bit.
I also added "tests/repos" to the pyright exclusion.

@Laurent2916 Laurent2916 self-assigned this Sep 26, 2024
@Laurent2916 Laurent2916 force-pushed the remove_useless_overloads_image_prompt branch from dc879d7 to 8c1e5bc Compare September 26, 2024 15:06
@Laurent2916 Laurent2916 changed the title Remove overloads in image_prompt.py Remove compute_clip_image_embedding overloads in image_prompt.py and tweak related docstring Sep 27, 2024
@Laurent2916 Laurent2916 force-pushed the remove_useless_overloads_image_prompt branch from 8c1e5bc to 8212d54 Compare September 27, 2024 09:17
@Laurent2916 Laurent2916 changed the title Remove compute_clip_image_embedding overloads in image_prompt.py and tweak related docstring Tweak compute_clip_image_embedding overloads Sep 27, 2024
@Laurent2916 Laurent2916 force-pushed the remove_useless_overloads_image_prompt branch from 8212d54 to 82cc0ad Compare September 27, 2024 09:19
@Laurent2916 Laurent2916 force-pushed the remove_useless_overloads_image_prompt branch from 82cc0ad to 901ede8 Compare September 27, 2024 09:50
@Laurent2916 Laurent2916 changed the title Tweak compute_clip_image_embedding overloads Removed compute_clip_image_embedding overloads Sep 27, 2024
@Laurent2916 Laurent2916 merged commit 07fc619 into main Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants