Drop old browsers support #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finesse
commented
Oct 18, 2024
| const version = getBrowserVersion() ?? { major: 0, minor: 0 } | ||
|
|
||
| // We do not want to call ua-parser-js in these tests, as those likely | ||
| // use navigator.userAgent internally. |
There was a problem hiding this comment.
I've removed the comment because getBrowserVersion and getBrowserEngineVersion use ua-parser-js under the hood
xnerhu
approved these changes
Oct 18, 2024
|
Hi @Finesse Please also publish a release at the same time, thank you. |
|
@tvvocold This is excessive because nothing changed in the runtime code |
|
I see, thx ; )
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dropped browsers:
FingerprintJS won't stop working in them immediately. We will just stop testing in these browsers. The PR also adds Samsung Internet to the list of tested browsers.
The above percents are of the Fingerprint Pro audience.