Merge pull request #58 from fingerprintjs/improve-error-reporting-for…

…-web Improve error reporting for web platform
fingerprintjs · Jan 19, 2024 · 2e7e374 · 2e7e374
2 parents 712f50b + 219467f
commit 2e7e374
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/lib/fpjs_pro_plugin_web.dart b/lib/fpjs_pro_plugin_web.dart
@@ -79,7 +79,11 @@ class FpjsProPluginWeb {
       _isExtendedResult = call.arguments['extendedResponseFormat'];
       _isInitialized = true;
     } catch (e) {
-      throw unwrapWebError(e as WebException);
+      if (e is WebException) {
+        throw unwrapWebError(e);
+      } else {
+        throw UnknownError(e.toString());
+      }
     }
   }
 
@@ -99,7 +103,11 @@ class FpjsProPluginWeb {
           fp.get(FingerprintJSGetOptions(linkedId: linkedId, tag: tags)));
       return result.visitorId;
     } catch (e) {
-      throw unwrapWebError(e as WebException);
+      if (e is WebException) {
+        throw unwrapWebError(e);
+      } else {
+        throw UnknownError(e.toString());
+      }
     }
   }
 
@@ -136,7 +144,11 @@ class FpjsProPluginWeb {
         serializedResult
       ];
     } catch (e) {
-      throw unwrapWebError(e as WebException);
+      if (e is WebException) {
+        throw unwrapWebError(e);
+      } else {
+        throw UnknownError(e.toString());
+      }
     }
   }
 }

diff --git a/lib/web_error.dart b/lib/web_error.dart
@@ -35,7 +35,7 @@ FingerprintProError unwrapWebError(WebException error) {
     return RequestTimeoutError(message);
   }
   if (message == FingerprintJS.ERROR_RATE_LIMIT) {
-    // return RequestTimeoutError(message); ???????
+    return TooManyRequestError(message);
   }
   if (message == FingerprintJS.ERROR_FORBIDDEN_ORIGIN) {
     return OriginNotAvailableError(message);