split cmakelist #384
Draft
split cmakelist #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olofkallander
force-pushed
the
testcmake
branch
2 times, most recently
from
a6cf554 to
6253895
Compare
olofkallander
commented
Nov 2, 2024
|
|
||
| target_link_libraries(LoadTest testlib gtest gmock) | ||
| add_subdirectory(test) | ||
| set_target_properties(UnitTest PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR} ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR} RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}) |
There was a problem hiding this comment.
This is to make Test executables end up in build top folder.
However, maybe we should consider allowing the build folder to be structured as cmake default:
build
bin
_deps
libs
and put the binaries in bin folder
olofkallander
commented
Nov 2, 2024
| include(FetchContent) | ||
|
|
||
| # Download and unpack googletest at configure time | ||
| configure_file(CMakeLists-gtest.txt.in googletest-download/CMakeLists.txt) |
There was a problem hiding this comment.
This should be done with fetchContent but it would require the cmake to be upgraded on all docker images first.
olofkallander
force-pushed
the
testcmake
branch
from
6d6272d to
be2c5aa
Compare
olofkallander
force-pushed
the
testcmake
branch
from
be2c5aa to
57c4f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the test build into its own cmakelist.
Upgraded gtest to 1.15.2
This PR should be updated once the new docker images are in use with make 3.30