Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui_auth): fix confirmation dialog for unlink account button in profile screen #373

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Mad-ScientistX
Copy link
Contributor

@Mad-ScientistX Mad-ScientistX commented Jul 18, 2024

Description

See #346
"Previously the wrong navigator was popped when cancelling or confirming the dialog. this resulted in the dialog still beeing visible and the navigator behind it beeing popped. the fix adds the context object to the function parameter, so the right navigator gets popped.".

This same logic needs to be applied to the showUnlinkConfirmationDialog dialog so it obtains the correct context and pops correctly.

Related Issues

fixes #212

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

google-cla bot commented Jul 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Mad-ScientistX Mad-ScientistX changed the title Fixed the context for the showUnlinkConfirmationDialog dialog fix(ui_auth): fix confirmation dialog for unlink account button in profile screen Jul 18, 2024
@russellwheatley russellwheatley merged commit 0e3a7c4 into firebase:main Oct 29, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 'Cancel' and 'Delete' actions of showDeleteConfirmationDialog pop the current view
2 participants