Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recaptcha Phone Auth #12970

Closed
wants to merge 24 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
06cbe83
inject recaptcha fields to mfa
pragatimodi May 15, 2024
bd852d1
Merge branch 'auth-swift' of https://github.com/firebase/firebase-ios…
pragatimodi May 31, 2024
5da2267
implement verifyWithRce
pragatimodi Jun 3, 2024
7dac824
lint
pragatimodi Jun 3, 2024
b83deca
[Firebase 11] Bump deps on GULs to v8 and GDT to v10 (#13036)
ncooke3 May 31, 2024
8af97bd
Fix Auth Domain search code to match comment (#13042)
paulb777 May 31, 2024
9f7bd0d
[Release] Update versions for Release 11.0.0 (#13046)
ncooke3 Jun 3, 2024
d555c66
[v11] Simplify Component System Usage (#13047)
paulb777 Jun 3, 2024
a4d38fc
[v11] Remove unused FIRDependency class (#13053)
paulb777 Jun 4, 2024
9b00cf8
[InAppMessaging] Remove InAppMessagingSwift (#13052)
ncooke3 Jun 4, 2024
16dc391
[v11] Address component system cleanup PR comments (#13055)
paulb777 Jun 4, 2024
067f427
[Analytics] Remove AnalyticsSwift (#13056)
ncooke3 Jun 4, 2024
61a299e
[v11] Drop support for deprecated notification methods (#13064)
paulb777 Jun 4, 2024
770a532
[v11] Update minimum platform versions for 11.0.0 (#13066)
paulb777 Jun 5, 2024
42ed431
[v11] RC stringValue is now nonull (#13065)
paulb777 Jun 5, 2024
22f8b05
[v11] Finish Messaging SecureCoding (#13069)
paulb777 Jun 5, 2024
4893b1d
[Firebase 11] Update to `swift-tools-version:5.9` in Package.swift (#…
andrewheard Jun 5, 2024
defbd6a
[Database] Remove DatabaseSwift (#13057)
ncooke3 Jun 5, 2024
dfd154c
[v11] Stop using GULSecureCoding (#13072)
paulb777 Jun 5, 2024
2ee630e
[v11] Clean up deprecated app delegate methods (#13073)
paulb777 Jun 5, 2024
ee92746
[Config] Remove ConfigSwift (#13076)
ncooke3 Jun 6, 2024
87ede37
[Firestore] Remove FirestoreSwift (#13085)
ncooke3 Jun 6, 2024
0afd004
[v11] Add changelog entries for Swift extension removal (#13086)
ncooke3 Jun 6, 2024
0e12fa3
[v11] Dependency version updates (#13093)
paulb777 Jun 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/client_app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ jobs:
matrix:
#TODO(ncooke3): Add multi-platform support: tvOS, macOS, catalyst
platform: [iOS]
scheme: [ClientApp, ClientApp-iOS13]
scheme: [ClientApp-iOS13]
# TODO(ncooke3): Re-enable after updating Firestore binary.
#scheme: [ClientApp, ClientApp-iOS13]
steps:
- uses: actions/checkout@v4
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/firestore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ jobs:
# Podspec
- 'FirebaseFirestoreInternal.podspec'
- 'FirebaseFirestore.podspec'
- 'FirebaseFirestoreSwift.podspec'

# CMake
- '**CMakeLists.txt'
Expand Down Expand Up @@ -462,8 +461,6 @@ jobs:
run: scripts/setup_spm_tests.sh
- name: iOS Build Test
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestore ${{ matrix.target }} spmbuildonly
- name: Swift Build
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestoreSwift ${{ matrix.target }} spmbuildonly

spm-binary:
# Either a scheduled run from public repo, or a pull request with firestore changes.
Expand All @@ -481,8 +478,6 @@ jobs:
run: scripts/setup_spm_tests.sh
- name: iOS Build Test
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestore iOS spmbuildonly
- name: Swift Build
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestoreSwift iOS spmbuildonly

check-firestore-internal-public-headers:
# Either a scheduled run from public repo, or a pull request with firestore changes.
Expand Down Expand Up @@ -534,8 +529,6 @@ jobs:
# run: scripts/setup_spm_tests.sh
# - name: Build Test - Binary
# run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestore ${{ matrix.target }} spmbuildonly
# - name: Swift Build
# run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestoreSwift ${{ matrix.target }} spmbuildonly

spm-binary-cron:
# Don't run on private repo.
Expand All @@ -553,8 +546,6 @@ jobs:
run: scripts/setup_spm_tests.sh
- name: Build Test - Binary
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestore ${{ matrix.target }} spmbuildonly
- name: Swift Build
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestoreSwift ${{ matrix.target }} spmbuildonly

# A job that fails if any required job in the test matrix fails,
# to be used as a required check for merging.
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/remoteconfig.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ jobs:
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
USE_REAL_CONSOLE: true
runs-on: macos-14
strategy:
matrix:
target: [iOS, tvOS, macOS]
target: [iOS]
steps:
- uses: actions/checkout@v4
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
Expand All @@ -40,13 +41,13 @@ jobs:
run: gem install xcpretty
- name: Install Secret GoogleService-Info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/RemoteConfigSwiftAPI/GoogleService-Info.plist.gpg \
FirebaseRemoteConfigSwift/Tests/SwiftAPI/GoogleService-Info.plist "$plist_secret"
FirebaseRemoteConfig/Tests/Swift/SwiftAPI/GoogleService-Info.plist "$plist_secret"
- name: Generate Access Token for RemoteConfigConsoleAPI in IntegrationTests
if: matrix.target == 'iOS'
run: ([ -z $plist_secret ] || scripts/generate_access_token.sh "$plist_secret" scripts/gha-encrypted/RemoteConfigSwiftAPI/ServiceAccount.json.gpg
FirebaseRemoteConfigSwift/Tests/AccessToken.json)
FirebaseRemoteConfig/Tests/Swift/AccessToken.json)
- name: Fake Console API Tests
run: scripts/third_party/travis/retry.sh scripts/build.sh RemoteConfig iOS fakeconsole
run: scripts/third_party/travis/retry.sh scripts/build.sh RemoteConfig ${{ matrix.target }} fakeconsole
- name: IntegrationTest
if: matrix.target == 'iOS'
# No retry to avoid exhausting AccessToken quota.
Expand All @@ -65,7 +66,8 @@ jobs:
include:
- os: macos-14
xcode: Xcode_15.3
tests:
# TODO(#13078): Fix testing infra to enforce warnings again.
tests: --allow-warnings
# Flaky tests on CI
- os: macos-13
xcode: Xcode_15.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
import Firebase

// Verify that the following Firebase Swift APIs can be found.
import FirebaseAnalyticsSwift
import FirebaseFirestoreSwift
import FirebaseInAppMessagingSwift
import FirebaseAnalytics
import FirebaseInAppMessaging
import UIKit

class CoreExists: FirebaseApp {}
Expand Down
4 changes: 1 addition & 3 deletions CoreOnly/Tests/FirebasePodTest/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,16 @@ target 'FirebasePodTest' do

pod 'Firebase', :path => '../../../'
pod 'FirebaseABTesting', :path => '../../../'
pod 'FirebaseAnalyticsSwift', :path => '../../../'
pod 'FirebaseAppDistribution', :path => '../../../'
pod 'FirebaseAuth', :path => '../../../'
pod 'FirebaseCore', :path => '../../../'
pod 'FirebaseCrashlytics', :path => '../../../'
pod 'FirebaseDatabase', :path => '../../../'
pod 'FirebaseDynamicLinks', :path => '../../../'
pod 'FirebaseFirestore', :path => '../../../'
pod 'FirebaseFirestoreSwift', :path => '../../../'
pod 'FirebaseFirestoreInternal', :path => '../../../'
pod 'FirebaseFunctions', :path => '../../../'
pod 'FirebaseInAppMessaging', :path => '../../../'
pod 'FirebaseInAppMessagingSwift', :path => '../../../'
pod 'FirebaseInstallations', :path => '../../../'
pod 'FirebaseMessaging', :path => '../../../'
pod 'FirebasePerformance', :path => '../../../'
Expand Down
7 changes: 0 additions & 7 deletions Crashlytics/Crashlytics/FIRCrashlytics.m
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,6 @@ + (void)load {
}

+ (NSArray<FIRComponent *> *)componentsToRegister {
FIRDependency *analyticsDep =
[FIRDependency dependencyWithProtocol:@protocol(FIRAnalyticsInterop)];

FIRDependency *sessionsDep =
[FIRDependency dependencyWithProtocol:@protocol(FIRSessionsProvider)];

FIRComponentCreationBlock creationBlock =
^id _Nullable(FIRComponentContainer *container, BOOL *isCacheable) {
if (!container.app.isDefaultApp) {
Expand All @@ -259,7 +253,6 @@ + (void)load {
FIRComponent *component =
[FIRComponent componentWithProtocol:@protocol(FIRCrashlyticsInstanceProvider)
instantiationTiming:FIRInstantiationTimingEagerInDefaultApp
dependencies:@[ analyticsDep, sessionsDep ]
creationBlock:creationBlock];
return @[ component ];
}
Expand Down
2 changes: 0 additions & 2 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,10 @@ has_license_changes = didModify(["LICENSE"])
## Product directories
@has_analytics_changes = hasChangesIn([
"FirebaseAnalyticsOnDeviceConversionWrapper",
"FirebaseAnalyticsSwift",
"FirebaseAnalyticsWithoutAdIdSupportWrapper",
"FirebaseAnalyticsWrapper"
]) || didModify([
"FirebaseAnalytics.podspec",
"FirebaseAnalyticsSwift.podspec",
"FirebaseAnalyticsOnDeviceConversion.podspec",
"GoogleAppMeasurement.podspec",
"GoogleAppMeasurementOnDeviceConversion.podspec"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

/* Begin PBXBuildFile section */
8817084726B95A63009E9281 /* FirebaseFirestore in Frameworks */ = {isa = PBXBuildFile; productRef = 8817084626B95A63009E9281 /* FirebaseFirestore */; };
8817084926B95A63009E9281 /* FirebaseFirestoreSwift in Frameworks */ = {isa = PBXBuildFile; productRef = 8817084826B95A63009E9281 /* FirebaseFirestoreSwift */; };
88327B8826D62908002AA6D9 /* FavouriteFruitsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 88327B8726D62908002AA6D9 /* FavouriteFruitsView.swift */; };
8844BA6126E0DD3F000786F0 /* FavouriteFruitsMappingErrorView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8844BA6026E0DD3F000786F0 /* FavouriteFruitsMappingErrorView.swift */; };
88D5E37826EBD2F200808AFF /* FavouriteFruitsMappingErrorView2.swift in Sources */ = {isa = PBXBuildFile; fileRef = 88D5E37726EBD2F200808AFF /* FavouriteFruitsMappingErrorView2.swift */; };
Expand Down Expand Up @@ -44,7 +43,6 @@
files = (
8817084726B95A63009E9281 /* FirebaseFirestore in Frameworks */,
88D9354C2A39D72300FD8AFF /* FirebaseAuth in Frameworks */,
8817084926B95A63009E9281 /* FirebaseFirestoreSwift in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -143,7 +141,6 @@
name = FirestoreSample;
packageProductDependencies = (
8817084626B95A63009E9281 /* FirebaseFirestore */,
8817084826B95A63009E9281 /* FirebaseFirestoreSwift */,
88D9354B2A39D72300FD8AFF /* FirebaseAuth */,
);
productName = FirestoreSample;
Expand Down Expand Up @@ -418,10 +415,6 @@
isa = XCSwiftPackageProductDependency;
productName = FirebaseFirestore;
};
8817084826B95A63009E9281 /* FirebaseFirestoreSwift */ = {
isa = XCSwiftPackageProductDependency;
productName = FirebaseFirestoreSwift;
};
88D9354B2A39D72300FD8AFF /* FirebaseAuth */ = {
isa = XCSwiftPackageProductDependency;
productName = FirebaseAuth;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// limitations under the License.

import FirebaseFirestore
import FirebaseFirestoreSwift
import SwiftUI

private struct Fruit: Codable, Identifiable, Equatable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import FirebaseFirestoreSwift
import FirebaseFirestore
import SwiftUI

private struct Fruit: Codable, Identifiable, Equatable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import FirebaseFirestoreSwift
import FirebaseFirestore
import SwiftUI

private struct Fruit: Codable, Identifiable, Equatable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// limitations under the License.

import FirebaseFirestore
import FirebaseFirestoreSwift
import SwiftUI

private struct Fruit: Codable, Identifiable, Equatable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// limitations under the License.

import FirebaseFirestore
import FirebaseFirestoreSwift
import SwiftUI

private struct Fruit: Codable, Identifiable, Equatable {
Expand Down
Loading
Loading