-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom signals support in Remote Config. #13976
base: main
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
Apple API Diff ReportCommit: f836efa FirebaseRemoteConfigEnumerations[ADDED] FIRRemoteConfigCustomSignalsError[ADDED] FIRRemoteConfigCustomSignalsErrorSwift:
+ typealias RemoteConfigCustomSignalsError . Code . _ErrorType = RemoteConfigCustomSignalsError
+ case unknown = 8101
+ case invalidValueType = 8102
+ case limitExceeded = 8103
Objective-C:
+ enum FIRRemoteConfigCustomSignalsError : NSInteger {}
+ FIRRemoteConfigCustomSignalsErrorUnknown = 8101
+ FIRRemoteConfigCustomSignalsErrorInvalidValueType = 8102
+ FIRRemoteConfigCustomSignalsErrorLimitExceeded = 8103 Constants[ADDED] FIRRemoteConfigCustomSignalsErrorDomain[ADDED] FIRRemoteConfigCustomSignalsErrorDomainSwift:
+ let RemoteConfigCustomSignalsErrorDomain : String
Objective-C:
+ extern NS_SWIFT_NAME ( RemoteConfigCustomSignalsErrorDomain ) NSString * const FIRRemoteConfigCustomSignalsErrorDomain ClassesFIRRemoteConfig[ADDED] -setCustomSignals:withCompletion:Objective-C:
+ - ( void ) setCustomSignals :( nonnull NSDictionary < NSString * , NSObject *> * ) customSignals withCompletion :( void ( ^ _Nullable )( NSError * _Nullable error )) completionHandler NS_REFINED_FOR_SWIFT ; |
FirebaseRemoteConfig/Tests/Swift/SwiftAPI/FirebaseRemoteConfigSwift_APIBuildTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tusharkhandelwal8 Thanks for working through all the feedback. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
feat(rc): Add method to set custom signals for Remote Config Custom targeting