Fix Installations access on background queue

Crashlytics/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [fixed] Fixed an issue where Installations was sometimes invoked off the main queue (#13961).
+
 # 11.5.0
 - [changed] Updated `upload-symbols` to version 3.19, removed all methods require CFRelease and switch to modern classes (#13420).
 

FirebasePerformance/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [fixed] Fixed an issue where Installations was sometimes invoked off the main queue (#13961).
+
 # 11.6.0
 - [fixed] Fix a crash related to registering for notifications when the app is between foreground or background states. (#13174)
 

FirebaseSessions/Sources/Settings/SettingsDownloadClient.swift

@@ -51,27 +51,31 @@ class SettingsDownloader: SettingsDownloadClient {
       return
     }
 
-    installations.installationID { result in
-      switch result {
-      case let .success(installationsInfo):
-        let request = self.buildRequest(url: validURL, fiid: installationsInfo.0)
-        let task = URLSession.shared.dataTask(with: request) { data, response, error in
-          if let data {
-            if let dict = try? JSONSerialization.jsonObject(with: data) as? [String: Any] {
-              completion(.success(dict))
-            } else {
-              completion(.failure(
-                .JSONParseError("Failed to parse JSON to dictionary")
-              ))
+    DispatchQueue.main.async {
+      // Installation's FIRInstallationsIDController isn't thread-safe, so this has to go
+      // on the main thread.
+      self.installations.installationID { result in
+        switch result {
+        case let .success(installationsInfo):
+          let request = self.buildRequest(url: validURL, fiid: installationsInfo.0)
+          let task = URLSession.shared.dataTask(with: request) { data, response, error in
+            if let data {
+              if let dict = try? JSONSerialization.jsonObject(with: data) as? [String: Any] {
+                completion(.success(dict))
+              } else {
+                completion(.failure(
+                  .JSONParseError("Failed to parse JSON to dictionary")
+                ))
+              }
+            } else if let error {
+              completion(.failure(.URLSessionError(error.localizedDescription)))
             }
-          } else if let error {
-            completion(.failure(.URLSessionError(error.localizedDescription)))
           }
+          // Start the task that sends the network request
+          task.resume()
+        case let .failure(error):
+          completion(.failure(.InstallationIDError(error.localizedDescription)))
         }
-        // Start the task that sends the network request
-        task.resume()
-      case let .failure(error):
-        completion(.failure(.InstallationIDError(error.localizedDescription)))
       }
     }
   }