Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CI_COMMIT_SHORT_SHA so it's always 8 characters #1007

Merged
merged 2 commits into from
Oct 24, 2023
Merged

fix CI_COMMIT_SHORT_SHA so it's always 8 characters #1007

merged 2 commits into from
Oct 24, 2023

Conversation

peterbbeu
Copy link
Contributor

@peterbbeu peterbbeu commented Oct 23, 2023 •
edited by firecow
Loading

Closes #1003

@peterbbeu peterbbeu force-pushed the fix-CI_COMMIT_SHORT_SHA-length branch from 9c1bc62 to 9138cc7 Compare October 23, 2023 11:35
@peterbbeu peterbbeu changed the title fix CI_COMMIT_SHORT_SHA so it's always 8 fix CI_COMMIT_SHORT_SHA so it's always 8 characters Oct 23, 2023
@peterbbeu peterbbeu force-pushed the fix-CI_COMMIT_SHORT_SHA-length branch from 9138cc7 to 7223265 Compare October 23, 2023 11:52
firecow
firecow reviewed Oct 23, 2023
View reviewed changes
Copy link
Owner

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a system call i git-data.ts that can be removed.

@peterbbeu
Copy link
Contributor Author

There is a system call i git-data.ts that can be removed.

Done

firecow
firecow approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks for your contribution 👍

@firecow firecow merged commit 3d24a7c into firecow:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firecow firecow firecow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI_COMMIT_SHORT_SHA is not always 8 characters
2 participants
@peterbbeu @firecow