Add a network namespace parameter to the CreateVM request

The current network namespace parameter nested in the JailerConfig parameter requires specifying the entire jailer configuration, which is not convenient and doesn't allow using the noop jailer with a network namespace. To overcome this limitation, add a new NetNS parameter to the CreateVM request. See also a similar change in firecracker-microvm/firecracker-go-sdk#155. Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
firecracker-microvm · Sep 8, 2023 · 57ac852 · 57ac852
1 parent 2a60b1c
commit 57ac852
Show file tree

Hide file tree

Showing 3 changed files with 77 additions and 62 deletions.
diff --git a/proto/firecracker.pb.go b/proto/firecracker.pb.go
diff --git a/proto/firecracker.proto b/proto/firecracker.proto
@@ -41,6 +41,9 @@ message CreateVMRequest {
     string MetricsFifoPath = 13;
 
     FirecrackerBalloonDevice BalloonDevice = 14;
+
+    // The network namespace of the VM.
+    string NetNS = 15;
 }
 
 message CreateVMResponse {

diff --git a/runtime/service.go b/runtime/service.go
@@ -985,6 +985,8 @@ func (s *service) buildVMConfiguration(req *proto.CreateVMRequest) (*firecracker
 
 	if req.JailerConfig != nil {
 		cfg.NetNS = req.JailerConfig.NetNS
+	} else {
+		cfg.NetNS = req.NetNS
 	}
 
 	s.logger.Debugf("using socket path: %s", cfg.SocketPath)