RTC-520 Add PeerAdded and PeerDeleted notifications (#37)

* Add PeerAdded and PeerDeleted notifications * Update protos
fishjam-dev · Apr 23, 2024 · 25c6e5a · 25c6e5a
1 parent 131186b
commit 25c6e5a
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 1 deletion.
diff --git a/jellyfish/events/__init__.py b/jellyfish/events/__init__.py
@@ -7,8 +7,10 @@
     ServerMessageComponentCrashed,
     ServerMessageHlsPlayable,
     ServerMessageMetricsReport,
+    ServerMessagePeerAdded,
     ServerMessagePeerConnected,
     ServerMessagePeerCrashed,
+    ServerMessagePeerDeleted,
     ServerMessagePeerDisconnected,
     ServerMessageRoomCrashed,
     ServerMessageRoomCreated,
@@ -24,7 +26,9 @@
     "ServerMessageRoomCreated",
     "ServerMessageRoomDeleted",
     "ServerMessageRoomCrashed",
+    "ServerMessagePeerAdded",
     "ServerMessagePeerConnected",
+    "ServerMessagePeerDeleted",
     "ServerMessagePeerDisconnected",
     "ServerMessagePeerCrashed",
     "ServerMessageComponentCrashed",

diff --git a/jellyfish/events/_protos/jellyfish/__init__.py b/jellyfish/events/_protos/jellyfish/__init__.py
diff --git a/protos b/protos
diff --git a/tests/test_notifier.py b/tests/test_notifier.py
@@ -12,7 +12,9 @@
 from jellyfish import ComponentOptionsFile, Notifier, PeerOptionsWebRTC, RoomApi
 from jellyfish.events import (
     ServerMessageMetricsReport,
+    ServerMessagePeerAdded,
     ServerMessagePeerConnected,
+    ServerMessagePeerDeleted,
     ServerMessagePeerDisconnected,
     ServerMessageRoomCreated,
     ServerMessageRoomDeleted,
@@ -121,8 +123,10 @@ async def test_peer_connected_disconnected(
     ):
         event_checks = [
             ServerMessageRoomCreated,
+            ServerMessagePeerAdded,
             ServerMessagePeerConnected,
             ServerMessagePeerDisconnected,
+            ServerMessagePeerDeleted,
             ServerMessageRoomDeleted,
         ]
         assert_task = asyncio.create_task(assert_events(notifier, event_checks.copy()))
@@ -156,8 +160,10 @@ async def test_peer_connected_disconnected_deleted(
     ):
         event_checks = [
             ServerMessageRoomCreated,
+            ServerMessagePeerAdded,
             ServerMessagePeerConnected,
             ServerMessagePeerDisconnected,
+            ServerMessagePeerDeleted,
             ServerMessageRoomDeleted,
         ]
 
@@ -194,7 +200,9 @@ async def test_peer_connected_room_deleted(
     ):
         event_checks = [
             ServerMessageRoomCreated,
+            ServerMessagePeerAdded,
             ServerMessagePeerConnected,
+            ServerMessagePeerDeleted,
             ServerMessageRoomDeleted,
         ]
         assert_task = asyncio.create_task(assert_events(notifier, event_checks.copy()))