Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Add e2e test #58

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Add e2e test #58

merged 8 commits into from
Nov 20, 2023

Conversation

szebniok
Copy link
Contributor

No description provided.

Copy link
Contributor

@kamil-stasiak kamil-stasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Please add a section to readme about e2e test. How to run them on osx, how to run them with colima and node greater than 16.

package.json Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
@kamil-stasiak
Copy link
Contributor

To add proper TS support in IntelliJ IDEA:

  • I installed:
npm install --save-dev @types/webrtc
  • In tsconfig.json I changed:
{
  "compilerOptions": {
    // ... 
    "skipLibCheck": true, // this
    "lib": ["es2020", "dom", "DOM.Iterable"], // this
    // ...
  },
  "include": ["src/**/*", "tests/**/*"] // this
}

What do you think about these changes?

@szebniok szebniok merged commit 04a6813 into main Nov 20, 2023
4 checks passed
@szebniok szebniok deleted the add-e2e-test branch November 20, 2023 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants