implemento mi solucion #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
propuesta de solucion |
laldonate96
reviewed
Oct 1, 2024
Comment on lines
+10
to
+12
| private ArrayList<Vehiculo> vehiculos = new ArrayList<Vehiculo>(); | ||
| private ArrayList<Cliente> clientes = new ArrayList<Cliente>(); | ||
| private ArrayList<Inmueble> inmuebles = new ArrayList<Inmueble>(); |
There was a problem hiding this comment.
La idea de la implementación de la interfaz Alquilable es justamente abstraer esto para no tener multiples listas con distintos tipos de Alquilables (imaginate que tenes 10 tipos de Alquilables distintos, tendrías 10 listas?)
laldonate96
reviewed
Oct 1, 2024
Comment on lines
+14
to
+30
| public void registrarVehiculo(Vehiculo unVehiculo) { | ||
| for(Vehiculo vehiculo: vehiculos){ | ||
| if(vehiculo.esIgualA(unVehiculo)){ | ||
| throw new VehiculoYaRegistradoException(); | ||
| } | ||
| } | ||
| vehiculos.add(unVehiculo); | ||
| } | ||
|
|
||
| void registrarInmueble(Inmueble unInmueble) { | ||
| for(Inmueble inmueble: inmuebles){ | ||
| if(inmueble.esIgualA(unInmueble)){ | ||
| throw new InmuebleYaRegistradoException(); | ||
| } | ||
| } | ||
| inmuebles.add(unInmueble); | ||
| } |
There was a problem hiding this comment.
Lo mismo acá, si tenés muchos alquilables? Serían muchos métodos para lo mismo
laldonate96
reviewed
Oct 1, 2024
Comment on lines
+52
to
+68
| private Vehiculo buscarVehiculo(Vehiculo unVehiculo) { | ||
| for(Vehiculo vehiculo: vehiculos){ | ||
| if(vehiculo.esIgualA(unVehiculo)){ | ||
| return vehiculo; | ||
| } | ||
| } | ||
| throw new VehiculoNoRegistradoException(); | ||
| } | ||
|
|
||
| private Inmueble buscarInmueble(Inmueble unInmueble){ | ||
| for(Inmueble inmueble: inmuebles){ | ||
| if(inmueble.esIgualA(unInmueble)){ | ||
| return inmueble; | ||
| } | ||
| } | ||
| throw new VehiculoNoRegistradoException(); | ||
| } |
laldonate96
reviewed
Oct 1, 2024
Comment on lines
+70
to
+77
| private Alquilable buscarAlquilable(Alquilable unAlquilable) { | ||
| if (unAlquilable instanceof Vehiculo) { | ||
| return buscarVehiculo((Vehiculo) unAlquilable); | ||
| } else if (unAlquilable instanceof Inmueble) { | ||
| return buscarInmueble((Inmueble) unAlquilable); | ||
| } | ||
| throw new AlquilableNoRegistradoException(); | ||
| } |
There was a problem hiding this comment.
Acá primero que nada instanceof está rompiendo tell dont ask, y la idea es usar polimorfismo con la abstrancción que te permite la implementación del alquilable.
laldonate96
reviewed
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.