Skip to content

Commit

Permalink
feat: Include all values in helm-values & deploy commands (#181)
Browse files Browse the repository at this point in the history
  • Loading branch information
jarojasm95 authored Oct 28, 2024
1 parent d400410 commit c987de9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion aladdin/charts/merger/templates/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{- $valuesYaml := toYaml .Values }}
{{- $values := .Values }}
{{- range untilStep 0 (int $templateValues) 1 }}
{{- $valuesYaml = tpl $valuesYaml (dict "Values" $values "Chart" $.Chart) }}
{{- $valuesYaml = tpl $valuesYaml (dict "Values" $values "Chart" $.Chart "Release" $.Release) }}
{{- $values = fromYaml $valuesYaml }}
{{- end }}
{{- $valuesYaml }}
3 changes: 2 additions & 1 deletion aladdin/commands/helm_values.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def parse_args(sub_parser):
help="show all values, including default values",
dest="all_values",
action="store_true",
default=True,
)
parser.add_argument(
"-o",
Expand All @@ -59,7 +60,7 @@ def helm_values(
uri: str,
git_ref: str = None,
chart: str = None,
all_values: bool = False,
all_values: bool = True,
output: str = None,
):
uri = urlparse(uri)
Expand Down
3 changes: 3 additions & 0 deletions aladdin/lib/k8s/helm.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ def upgrade(
force=False,
dry_run=False,
helm_args: list = None,
all_values=True,
**values,
):
if helm_args is None:
Expand All @@ -148,6 +149,8 @@ def upgrade(
"--install",
f"--namespace={namespace}",
]
if all_values:
command.append(f"--values={chart_path}/values.yaml")

command = self.prepare_command(
command, chart_path, values_files, namespace, helm_args=helm_args, **values
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "aladdin"
version = "1.29.8.6"
version = "1.29.8.7"
description = ""
authors = ["Fivestars <dev@fivestars.com>"]
include = [
Expand Down

0 comments on commit c987de9

Please sign in to comment.