Feature: Add home_total_amount to the stg_quickbooks__deposit model
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-avinash
changed the title
home_total_amount to the stg_quickbooks__deposit model
fivetran-joemarkiewicz
requested changes
Jul 17, 2024
| @@ -44,6 +44,7 @@ final as ( | |||
| currency_id, | |||
| cast(department_id as {{ dbt.type_string() }}) as department_id, | |||
| total_amount, | |||
| home_total_amount, | |||
| @@ -45,6 +45,7 @@ final as ( | |||
| customer_id, | |||
| cast(department_id as {{ dbt.type_string() }}) as department_id, | |||
| cast( {{ dbt.date_trunc('day', 'due_date') }} as date) as due_date, | |||
| exchange_rate, | |||
There was a problem hiding this comment.
@fivetran-joemarkiewicz Changes applied and docs regenerated, ready for re-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Supporting issues filed in
dbt_quickbooks, particularly 115 and 128This PR will result in the following new package version: v0.10.1
We are adding a new field, but it should not impact existing customers to be breaking. (Given the scale of the concurrent PR in the transform package, I'd be open to making this breaking though)
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🎉 Feature Update 🎉
home_total_amountfield into thestg_quickbooks__depositmodel to support the new multicurrency feature in the v0.14.0 release of thedbt_quickbookspackage.🚘 Under the Hood 🚘
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validation details are in the transformation package, but did confirm the new column is being applied correctly in the
dbt_quickbooksPR #134.If you had to summarize this PR in an emoji, which would it be?
💴 💷 💶