-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydrate MDX #220
Merged
Merged
Hydrate MDX #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NickHeiner
changed the title
Add a prop so
Hydrate output of Jul 29, 2023
MdxChatCompletion
only emits valid outputMdxChatCompletion
NickHeiner
changed the title
Hydrate output of
[WIP] Hydrate output of Jul 29, 2023
MdxChatCompletion
MdxChatCompletion
NickHeiner
commented
Jul 31, 2023
NickHeiner
changed the title
[WIP] Hydrate output of
Hydrate output of Jul 31, 2023
MdxChatCompletion
MdxChatCompletion
This reverts commit a056d45.
NickHeiner
commented
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this approach, we compile MDX on the client.
Pros:
Card
) in scope – no need to pass them up and down to the server.useChat
paved path.Potential objections
O(count of stream chunks)
compiles – I don't think this will be noticeable, particularly in context of LLM response times.Future work
Badge
needs acolor
prop (e.g.<Badge color="yellow">In progress</Badge>
), but the model does not always do that. There may be more prompt engineering work we can do here.<details>
and<summary>
in a way that causes the compiler to produce<details><p><summary>,
which is invalid.I think this approach will work reasonable well for RSC / Architecture 4, with some modification.
Once we align on this approach, I'll add docs.