Migrate FixieCorpus to the new (beta) corpus API. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I vote for simplicity and just cutting over to the new API. |
NickHeiner
reviewed
Aug 28, 2023
NickHeiner
reviewed
Aug 28, 2023
NickHeiner
reviewed
Aug 28, 2023
NickHeiner
reviewed
Aug 28, 2023
mdepinet
approved these changes
Aug 28, 2023
|
Thanks for the comments - PTAL |
mdwelsh
force-pushed
the
mdw/new-corpus-api
branch
from
74ce814
to
8f92ec3
Compare
NickHeiner
reviewed
Aug 28, 2023
NickHeiner
approved these changes
Aug 28, 2023
NickHeiner
reviewed
Aug 28, 2023
Co-authored-by: Nick Heiner <NickHeiner@users.noreply.github.com>
…mdw/new-corpus-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new corpus service is currently only deployed on beta.fixie.ai, however, it should be more reliable and useful than the existing app.fixie.ai API. Hence this PR updates AI.JSX's
FixieCorpuscomponent to use the new API surface. I've also added a little demo program for the component.If we want to retain support for the old API, I'm happy to rename this component to something like
FixieCorpusNewor add a flag or something to use the new API instead - feedback welcome!