Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and transpile external stylesheets - fixes #78. #242

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

flackr
Copy link
Owner

@flackr flackr commented Feb 9, 2024

In this implementation, a stylesheet's href is replaced with an object URL to the updated stylesheet href.

@flackr
Copy link
Owner Author

flackr commented Feb 13, 2024

@calinoracation Does this look good as a first step and we can add the timeout and cross-origin whitelist as extra options? It might also be fine to make requests for all css files even if they might fail CORS.

Copy link
Contributor

@calinoracation calinoracation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks great. Totally in agreement on follow-up to either have an allow list or simply parse everything option and deal with the errors.

@flackr flackr merged commit 168c842 into master Feb 14, 2024
2 checks passed
@bramus bramus mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants