-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added AlignComponent layout component #2350
Commits on Feb 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 53f4356 - Browse repository at this point
Copy the full SHA 53f4356View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aa006f - Browse repository at this point
Copy the full SHA 3aa006fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 890d05a - Browse repository at this point
Copy the full SHA 890d05aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9714ceb - Browse repository at this point
Copy the full SHA 9714cebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94c2d2d - Browse repository at this point
Copy the full SHA 94c2d2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73c15b1 - Browse repository at this point
Copy the full SHA 73c15b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa19f88 - Browse repository at this point
Copy the full SHA fa19f88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1805cb2 - Browse repository at this point
Copy the full SHA 1805cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2e2e23 - Browse repository at this point
Copy the full SHA d2e2e23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 560dd4c - Browse repository at this point
Copy the full SHA 560dd4cView commit details
Commits on Feb 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a624018 - Browse repository at this point
Copy the full SHA a624018View commit details
Commits on Mar 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4037bcb - Browse repository at this point
Copy the full SHA 4037bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e92194 - Browse repository at this point
Copy the full SHA 2e92194View commit details -
Configuration menu - View commit details
-
Copy full SHA for d838f52 - Browse repository at this point
Copy the full SHA d838f52View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7aa2c1 - Browse repository at this point
Copy the full SHA d7aa2c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fe90f7 - Browse repository at this point
Copy the full SHA 6fe90f7View commit details
Commits on Mar 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b62481c - Browse repository at this point
Copy the full SHA b62481cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4a6963 - Browse repository at this point
Copy the full SHA f4a6963View commit details -
refactor: Remove unused variable "tapTimes" from multi_touch_tap_dete…
…ctor_test.dart (#2379) This is a cleanup identified on this issue: #2308 Using an amazing unused-code tooling Now, since Flame is a public API, unused code might not be trivial - it might just mean untested code. This one was a no-brainer -- the variable was clearly replaced by specific counters during the writing of the test and forgotten there: int nOnTapDown = 0; int nOnLongTapDown = 0; int nOnTapUp = 0; int nOnTap = 0; int nOnTapCancel = 0; It wasn't even increment and the taps are already thoroughly tested more granularly
Configuration menu - View commit details
-
Copy full SHA for 34a1fd5 - Browse repository at this point
Copy the full SHA 34a1fd5View commit details -
test: Add test for the intersections test helper method (#2378)
This is a cleanup identified on this issue: #2308 Using an amazing unused-code tooling Now, since Flame is a public API, unused code might not be trivial - it might just mean untested code. In this case, we have a test helper, which is a public function we expose to help people write better tests. Which means that the function could be useful, it was just lacking a test -- so I added it. That being said, if this method is deemed unnecessary for users, I can just remove it instead - lmk.
Configuration menu - View commit details
-
Copy full SHA for 62e45c7 - Browse repository at this point
Copy the full SHA 62e45c7View commit details -
refactor: Use variable name on toString in component_test.dart (#2377)
This is a cleanup identified on this issue: #2308 Using an amazing unused-code tooling Now, since Flame is a public API, unused code might not be trivial - it might just mean untested code. In this case, the unused code is in the tests, which likely means it is indeed necessary. I tried to infer the intent of the author here, and even considered adding the names of the components to the events, but the events are already always per component, so that was meaningless. I also thought it might be a missing toString, that they would wish to show the component name for debugging purposes, but I didn't see any asserts/logs on the component objects themselves (just the events). So I concluded there is no reason to keep this field, but lmk if anyone disagrees and I can bring it back and add some function to it.
Configuration menu - View commit details
-
Copy full SHA for da5ac3b - Browse repository at this point
Copy the full SHA da5ac3bView commit details -
refactor: Remove unused event "ScoreEventCleared" from flame_block ex…
…ample (#2380) # Description This is a cleanup identified on this issue: #2308 Using an amazing unused-code tooling Now, since Flame is a public API, unused code might not be trivial - it might just mean untested code. Since this an example package, it definitely should never have unused code. In this case, the constructor wasn't being used, but upon deeper investigation, that was because this particular event wasn't ever fired at all. So I removed it entirely. If this was supposed to be fired somewhere by the example, please lmk and I can add the missing firing. But as far as I can see, the event serves no purpose in this example. ## Checklist - [x] I have followed the [Contributor Guide] when preparing my PR. - [x] I have updated/added tests for ALL new/updated/fixed functionality. - [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`. - [x] I have updated/added relevant examples in `examples` or `docs`. ## Breaking Change? - [ ] Yes, this PR is a breaking change. - [x] No, this PR is not a breaking change. <!-- Links --> [Contributor Guide]: https://github.com/flame-engine/flame/blob/main/CONTRIBUTING.md [Conventional Commit]: https://conventionalcommits.org/ [CHANGELOG]: https://github.com/flame-engine/flame/blob/main/CHANGELOG.md Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
Configuration menu - View commit details
-
Copy full SHA for 4e964af - Browse repository at this point
Copy the full SHA 4e964afView commit details -
chore: Standardize and unify SDK versions across packages (#2374)
# Description This does two things: ## Use double quotes for SDK constraints Standardize the usage of single or double quotes to specify sdk constraints across pubspecs I see no reason this should not be kept consistent I also see no reason to prefer one over the other, so I searched the code base and there are 7 instances of single quote vs 32 of double quotes, so I favored the later ## Update all SDK constraints to 2.18 Let me know if there are any issues with it, but I believe we should keep this consistent across all packages. Also there is a pubspec on root which imply all should be on 2.18 anyway. ## Checklist - [x] I have followed the [Contributor Guide] when preparing my PR. - [x] I have updated/added tests for ALL new/updated/fixed functionality. - [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`. - [x] I have updated/added relevant examples in `examples` or `docs`. ## Breaking Change? - [ ] Yes, this PR is a breaking change. - [x] No, this PR is not a breaking change. <!-- Links --> [Contributor Guide]: https://github.com/flame-engine/flame/blob/main/CONTRIBUTING.md [Conventional Commit]: https://conventionalcommits.org/ [CHANGELOG]: https://github.com/flame-engine/flame/blob/main/CHANGELOG.md Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
Configuration menu - View commit details
-
Copy full SHA for 002383d - Browse repository at this point
Copy the full SHA 002383dView commit details -
docs: Remove outdated index of contents from packages/README (#2375)
This list was wildly outdated. I could updated it but after consideration I thought there was no value to list the directory structure that was already represented in the github view. Happy to pivot to just updating it though if there are preferences.
Configuration menu - View commit details
-
Copy full SHA for 10aa5e9 - Browse repository at this point
Copy the full SHA 10aa5e9View commit details -
test: Add test for two subsequent state changes to flame_multi_bloc_p…
…rovider_test.dart (#2381) This is a cleanup identified on this issue: #2308 Using an amazing unused-code tooling Now, since Flame is a public API, unused code might not be trivial - it might just mean untested code. In this case, it is a test file, so there should definitely be no unused code. However analyzing the unused code revealed to me some intent of testing multiple subsequent state changes (dead -> raise from dead). I believe such test was missing entirely, so I added it. I think it holds value, but lmk if you disagree I can just delete the test and the method.
Configuration menu - View commit details
-
Copy full SHA for 775de23 - Browse repository at this point
Copy the full SHA 775de23View commit details -
docs: Break out overlays docs (#2384)
The docs for overlays were a bit hard to find so I broke them out to its own section. They could need some some updating too with more examples and instructions.
Configuration menu - View commit details
-
Copy full SHA for b4b8b7c - Browse repository at this point
Copy the full SHA b4b8b7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1690d0c - Browse repository at this point
Copy the full SHA 1690d0cView commit details