Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Improve speed #11

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

Dan-Crane
Copy link
Contributor

Description

This tmp PR that should improve performance.

The first thing to pay attention to is:

  1. benchmarks.
  2. changes in the API.

If you are satisfied with everything. The next step would be:

  1. add more tests.
  2. write CnangeLog
  3. write documentation
  4. change the example

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The dart analyzer (dart analyze) does not report any problems on my PR.
  • I read and followed the Effective Dart Style Guide.
  • I have added a description of the change under [next] in CHANGELOG.md.
  • I am willing to follow-up on review comments in a timely manner.
  • I am happy with the current version of this PR and it is ready to be reviewed
  • If the PR still has the Draft status, remove it by clicking on the Ready for review button in this PR.

Breaking Change

Does your PR require Oxygen users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md).
  • No, this is not a breaking change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR

@spydon spydon requested a review from wolfenrain May 14, 2022 12:47
@spydon
Copy link
Member

spydon commented Sep 21, 2022

The pipeline is now (finally) fixed if you want to continue this branch @Dan-Crane

@spydon
Copy link
Member

spydon commented Jan 28, 2024

@Dan-Crane are you interested in continuing working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants