Skip to content

Commit

Permalink
fix: update push tags (#15)
Browse files Browse the repository at this point in the history
  • Loading branch information
yashmehrotra authored Sep 5, 2024
1 parent 6b2eff7 commit bc2c91d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ jobs:
id: build
uses: docker/build-push-action@v6
with:
tags: ${{ env.REGISTRY_IMAGE }}:${{env.TIMESTAMP}},${{ env.REGISTRY_IMAGE }}:${{ env.SHA }}
#tags: ${{ env.REGISTRY_IMAGE }}:${{env.TIMESTAMP}},${{ env.REGISTRY_IMAGE }}:${{ env.SHA }}
tags: ${{ env.REGISTRY_IMAGE }}
platforms: ${{ matrix.platform }}
labels: ${{ steps.meta.outputs.labels }}
outputs: type=image,name=${{ env.REGISTRY_IMAGE }},push-by-digest=true,name-canonical=true,push=true
Expand Down
8 changes: 7 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,16 @@ ARG TARGETARCH
ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update && \
apt-get install -y curl unzip ca-certificates zip tzdata wget gnupg2 bzip2 apt-transport-https lsb-release git python3-crcmod python3-openssl --no-install-recommends && \
apt-get install -y curl unzip ca-certificates zip tzdata wget gnupg2 bzip2 apt-transport-https locales locales-all lsb-release git python3-crcmod python3-openssl --no-install-recommends && \
apt-get clean

RUN apt-get update && apt-get upgrade -y && \
rm -Rf /var/lib/apt/lists/* && \
apt-get clean

RUN locale-gen en_US.UTF-8
RUN update-locale LANG=en_US.UTF-8

# stern, jq, yq
RUN curl -sLS https://get.arkade.dev | sh && \
arkade get kubectl stern jq yq sops --path /usr/bin && \
Expand Down Expand Up @@ -104,6 +107,9 @@ fi && \
FROM base AS final

# Install all locales
RUN locale-gen en_US.UTF-8
RUN update-locale LANG=en_US.UTF-8

RUN apt-get install -y locales locales-all

ENV PATH /opt/google-cloud-sdk/bin:$PATH

Check warning on line 115 in Dockerfile

View workflow job for this annotation

GitHub Actions / base (linux/amd64, ubuntu-latest)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 115 in Dockerfile

View workflow job for this annotation

GitHub Actions / base (linux/arm64, ubuntu-arm64)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
Expand Down

0 comments on commit bc2c91d

Please sign in to comment.