feat: trim down on extraneous calls to ConsumeUntilEmpty in event consumers #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/improve-event-consumer
branch
3 times, most recently
from
0537818
to
2116d63
Compare
adityathebe
force-pushed
the
feat/improve-event-consumer
branch
from
2116d63
to
34cfde1
Compare
adityathebe
commented
Nov 5, 2024
| @@ -27,9 +27,7 @@ const ( | |||
| DefaultEventLogSize = 20 | |||
| ) | |||
|
|
|||
| type Handler func(ctx context.Context, e models.Event) error | |||
There was a problem hiding this comment.
type Handler is not required anymore since we merged postq into duty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: flanksource/duty#1105