Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create agent api #475

Merged
merged 15 commits into from
Aug 21, 2023
Merged

feat: create agent api #475

merged 15 commits into from
Aug 21, 2023

Conversation

adityathebe
Copy link
Member

Resolves: #465

@adityathebe adityathebe marked this pull request as ready for review August 3, 2023 11:41
@adityathebe adityathebe marked this pull request as draft August 3, 2023 11:43
adityathebe
adityathebe commented Aug 4, 2023
View reviewed changes
auth/middleware.go Outdated Show resolved Hide resolved
adityathebe
adityathebe commented Aug 4, 2023
View reviewed changes
db/people.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
db/people.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
db/people.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
db/people.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
rbac/init.go
@@ -124,6 +127,8 @@ func Init(adminUserID string) error {
{RoleResponder, ObjectDatabaseIncident, ActionUpdate},

{RoleViewer, ObjectDatabase, ActionRead},

{RoleAgent, ObjectAgentPush, ActionWrite},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agent should only have access to call the API that would be used when pushing upstream

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already that way?

moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
db/agents.go Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
auth/middleware.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
auth/middleware.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
auth/middleware.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Aug 4, 2023
View reviewed changes
agent/agent.go Outdated Show resolved Hide resolved
@adityathebe
feat: use argon2 instead of bcrypt
016b211 
argon2 allows us to supply the salt whereas bcrypt doesn't.
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2023
View reviewed changes
auth/middleware.go Fixed Show fixed Hide fixed
auth/middleware.go Fixed Show fixed Hide fixed
auth/middleware.go Fixed Show fixed Hide fixed
@adityathebe adityathebe marked this pull request as ready for review August 8, 2023 06:01
yashmehrotra
yashmehrotra reviewed Aug 8, 2023
View reviewed changes
utils/utils.go Outdated Show resolved Hide resolved
adityathebe
adityathebe commented Aug 8, 2023
View reviewed changes
cmd/server.go Outdated Show resolved Hide resolved
@moshloop moshloop merged commit a9f7d84 into main Aug 21, 2023
5 checks passed
@moshloop moshloop deleted the feat/agent-api branch August 21, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashmehrotra yashmehrotra yashmehrotra left review comments

@moshloop moshloop moshloop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Agent API
3 participants
@adityathebe @moshloop @yashmehrotra