Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream test #497

Merged
merged 10 commits into from
Aug 21, 2023
Merged

fix: upstream test #497

merged 10 commits into from
Aug 21, 2023

Conversation

adityathebe
Copy link
Member

Resolves: #486

There's a bug in upstream test where we are always comparing two empty slices.
https://github.com/flanksource/incident-commander/blob/main/events/upstream_test.go#L305

@adityathebe
Copy link
Member Author

Wait for flanksource/duty#249

go.mod Outdated Show resolved Hide resolved
@adityathebe adityathebe marked this pull request as ready for review August 18, 2023 03:54
@adityathebe
Copy link
Member Author

@moshloop Can we merge this now since flanksource/duty#249 got merged

@moshloop moshloop merged commit abf194a into main Aug 21, 2023
5 checks passed
@moshloop moshloop deleted the improve-upstream-test branch August 21, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test for upstream push
2 participants