-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upstream test #497
Merged
Merged
fix: upstream test #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for flanksource/duty#249 |
adityathebe
commented
Aug 18, 2023
[skip ci]
manner. * experimenting with a single consumer because 5 consumers for upstream push always fails to push a check status for some reason.
[skip ci]
[skip ci]
adityathebe
force-pushed
the
improve-upstream-test
branch
from
August 21, 2023 16:15
dfc9c26
to
51e6b66
Compare
@moshloop Can we merge this now since flanksource/duty#249 got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #486
There's a bug in upstream test where we are always comparing two empty slices.
https://github.com/flanksource/incident-commander/blob/main/events/upstream_test.go#L305