Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default title and body for notifications #535

Merged
merged 16 commits into from
Sep 11, 2023

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Sep 6, 2023

Resolves: #533
Resvoles: #532

@adityathebe
Copy link
Member Author

Will implement #532 in this PR

@adityathebe
Copy link
Member Author

@moshloop I tried formatting the URLs but Shoutrrr doesn't support that at the moment (example: Slack).
And we would also need to specify whether to use markdown or HTML per service.

So, for now I've simply added raw URL in the default templates.

@adityathebe adityathebe linked an issue Sep 6, 2023 that may be closed by this pull request
cmd/root.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
@moshloop
Copy link
Member

moshloop commented Sep 7, 2023

@adityathebe

  • Rather than agent_id:00000000-0000-0000-0000-000000000000 canary_id:018824e5-d0f5-246b-b111-d8ac02c98229 we should have agent: {id: 000, name: xyz), canary: {id: 000, name: canary, namespace: default}
  • Add error / message to check template
  • Add formatted labels
  • Check uptime/latency being 0

@adityathebe adityathebe force-pushed the feat/default-subject-body-notification branch from 676218c to 6c8af47 Compare September 7, 2023 10:09
cmd/root.go Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
events/notifications.go Outdated Show resolved Hide resolved
@moshloop moshloop enabled auto-merge (squash) September 11, 2023 08:22
@moshloop moshloop merged commit b056221 into main Sep 11, 2023
4 checks passed
@moshloop moshloop deleted the feat/default-subject-body-notification branch September 11, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications - Add default subject/body Notifications - add permlink
2 participants