fix: support connection lookup by ID #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this already done via https://github.com/flanksource/duty/blob/main/connection.go#L67 ? or maybe we just need to handle the |
|
@moshloop ya duty already handles it. However, incident commander was returning nil if the connection name didn't have |
|
@adityathebe I think then lets add the support for the prefix in duty |
|
@moshloop This PR is still needed though. Otherwise, HydrateConnection will never hit duty when a UUID is provided. |
|
@adityathebe - ok but then the handling of nils and uuid's should still be in duty which should accept either a uuid or a connection string |
|
Related: flanksource/duty#275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: flanksource/flanksource-ui#1378