Skip to content

Commit

Permalink
Remove auction transcript code (#629)
Browse files Browse the repository at this point in the history
  • Loading branch information
jtraglia authored Mar 22, 2024
1 parent d263722 commit 8b662e0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 32 deletions.
6 changes: 3 additions & 3 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ curl localhost:18550/eth/v1/builder/status

For example, creating a new release `v1.9`:

1. Create a Github issue about the upcoming release ([example](https://github.com/flashbots/mev-boost/issues/524))
1. Create a GitHub issue about the upcoming release ([example](https://github.com/flashbots/mev-boost/issues/524))
2. Create a release branch: `release/v1.9` (note: use the target version as branch name, don't add the `-alpha` suffix)
3. Tag an alpha version: `v1.9-alpha1`
4. Test in testnets, iterate as needed, create more alpha versions if needed
Expand Down Expand Up @@ -95,10 +95,10 @@ To create a new version (with tag), follow all these steps! They are necessary t
* Update the `develop` branch:
* `git checkout develop`
* `git merge tags/v1.9 --ff-only`
* Update `Version` in `config/vars.go` to next patch with `dev` suffix (eg. `v1.10-dev`) and commit to `develop` branch
* Update `Version` in `config/vars.go` to next patch with `dev` suffix (e.g. `v1.10-dev`) and commit to `develop` branch
* Now push the `develop` and `stable` branches, as well as the tag: `git push origin develop stable --tags`

Now check the Github CI actions for release activity: https://github.com/flashbots/mev-boost/actions
Now check the GitHub CI actions for release activity: https://github.com/flashbots/mev-boost/actions
* CI builds and pushes the Docker image, and prepares a new draft release in https://github.com/flashbots/mev-boost/releases
* Open it and prepare the release:
* generate the description
Expand Down
3 changes: 0 additions & 3 deletions server/backend.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,4 @@ const (
pathRegisterValidator = "/eth/v1/builder/validators"
pathGetHeader = "/eth/v1/builder/header/{slot:[0-9]+}/{parent_hash:0x[a-fA-F0-9]+}/{pubkey:0x[a-fA-F0-9]+}"
pathGetPayload = "/eth/v1/builder/blinded_blocks"

// // Relay Monitor paths
// pathAuctionTranscript = "/monitor/v1/transcript"
)
26 changes: 0 additions & 26 deletions server/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
builderApi "github.com/attestantio/go-builder-client/api"
builderApiV1 "github.com/attestantio/go-builder-client/api/v1"
builderSpec "github.com/attestantio/go-builder-client/spec"
eth2ApiV1Bellatrix "github.com/attestantio/go-eth2-client/api/v1/bellatrix"
eth2ApiV1Capella "github.com/attestantio/go-eth2-client/api/v1/capella"
eth2ApiV1Deneb "github.com/attestantio/go-eth2-client/api/v1/deneb"
"github.com/attestantio/go-eth2-client/spec/phase0"
Expand Down Expand Up @@ -51,12 +50,6 @@ type httpErrorResp struct {
Message string `json:"message"`
}

// AuctionTranscript is the bid and blinded block received from the relay send to the relay monitor
type AuctionTranscript struct {
Bid *builderSpec.VersionedSignedBuilderBid // TODO: proper json marshalling and unmarshalling
Acceptance *eth2ApiV1Bellatrix.SignedBlindedBeaconBlock `json:"acceptance"`
}

type slotUID struct {
slot uint64
uid uuid.UUID
Expand Down Expand Up @@ -231,22 +224,6 @@ func (m *BoostService) sendValidatorRegistrationsToRelayMonitors(payload []build
}
}

// func (m *BoostService) sendAuctionTranscriptToRelayMonitors(transcript *AuctionTranscript) {
// log := m.log.WithField("method", "sendAuctionTranscriptToRelayMonitors")
// for _, relayMonitor := range m.relayMonitors {
// go func(relayMonitor *url.URL) {
// url := GetURI(relayMonitor, pathAuctionTranscript)
// log := log.WithField("url", url)
// _, err := SendHTTPRequest(context.Background(), *http.DefaultClient, http.MethodPost, url, UserAgent(""), nil, transcript, nil)
// if err != nil {
// log.WithError(err).Warn("error sending auction transcript to relay monitor")
// return
// }
// log.Debug("sent auction transcript to relay monitor")
// }(relayMonitor)
// }
// }

func (m *BoostService) handleRoot(w http.ResponseWriter, _ *http.Request) {
m.respondOK(w, nilResponse)
}
Expand Down Expand Up @@ -561,9 +538,6 @@ func (m *BoostService) processCapellaPayload(w http.ResponseWriter, req *http.Re
log.Warn("bid found but no associated relays")
}

// send bid and signed block to relay monitor with eth2ApiV1Capella payload
// go m.sendAuctionTranscriptToRelayMonitors(&AuctionTranscript{Bid: originalBid.response.Data, Acceptance: payload})

// Add request headers
headers := map[string]string{HeaderKeySlotUID: slotUID}

Expand Down

0 comments on commit 8b662e0

Please sign in to comment.