Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to cmd/test-cli #578

Closed
wants to merge 6 commits into from

Conversation

MCarlomagno
Copy link
Contributor

@MCarlomagno MCarlomagno commented Oct 19, 2023

📝 Summary

Adding very simple unit tests (that didn't require any refactor) for cmd/test-cli/beacon.go.

⛱ Motivation and Context

Lack of unit tests under cmd/test-cli/.
Ideally, I would like to work towards some kind of refactor in order to add more tests to the rest of scripts under this folder, by creating injected dependencies and mocking them.

📚 References

#577

✅ I have run these commands

  • make lint
  • make test
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #578 (f174c47) into develop (190d459) will decrease coverage by 17.03%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           develop     #578       +/-   ##
============================================
- Coverage    69.69%   52.66%   -17.03%     
============================================
  Files            7       12        +5     
  Lines         1102     1462      +360     
============================================
+ Hits           768      770        +2     
- Misses         288      644      +356     
- Partials        46       48        +2     
Flag Coverage Δ
unittests 52.66% <ø> (-17.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@metachris
Copy link
Collaborator

What's the goal of the test you've added here?

@metachris metachris closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants