Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deneb follow up #608

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Deneb follow up #608

merged 1 commit into from
Jan 22, 2024

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Jan 16, 2024

πŸ“ Summary

Some logging and test improvements

β›± Motivation and Context

Follow up PR addressing comments on #553.

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

Base automatically changed from develop-deneb to develop January 19, 2024 10:40
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4ff4d89) 67.74% compared to head (8d83655) 68.07%.

Files Patch % Lines
server/service.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #608      +/-   ##
===========================================
+ Coverage    67.74%   68.07%   +0.32%     
===========================================
  Files            7        7              
  Lines         1203     1206       +3     
===========================================
+ Hits           815      821       +6     
  Misses         331      331              
+ Partials        57       54       -3     
Flag Coverage Ξ”
unittests 68.07% <0.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@metachris metachris merged commit 4702ceb into develop Jan 22, 2024
4 checks passed
@metachris metachris deleted the deneb-follow-up branch January 22, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants